Add "trending" sort order to search page #5202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pypi#3447 Add zscore to Project document mapping Add zscore to `_project_docs` query to populate on reindex Add "Trending" sort order to search ordering dropdown
|
I think we probably want to break this into two PRs:
That way, we can deploy #1, let the index rebuild (IIRC this is happening every 6 hours now?) and then deploy #2. |
|
I'll be splitting this PR into two as suggested, but I while working on this I found I agree with #3932. I think if we included the package's downloads in the index and give it a boost score we could have the standard search align more to the results expected by users. Does that sound reasonable? I could include it in the first split PR from this one if so. |
This was referenced Jan 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3447
Add zscore to Project document mapping
Add zscore to
_project_docsquery to populate on reindexAdd "Trending" sort order to search ordering dropdown
The results in the screenshot are not particularly relevant since I populated the
zscorewith random values on 100 project. It'd be nice to test it with proper values if possible to guage how useful the sort order is.