Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEP 625 #4286

Merged
merged 7 commits into from
Apr 12, 2024
Merged

Support PEP 625 #4286

merged 7 commits into from
Apr 12, 2024

Conversation

di
Copy link
Member

@di di commented Mar 20, 2024

Summary of changes

Support PEP 625 by canonicalizing package name and version in filenames.

Closes #3593.

Pull Request Checklist

@di
Copy link
Member Author

di commented Mar 20, 2024

Hmm, the failing test doesn't fail for me locally.

@di
Copy link
Member Author

di commented Mar 20, 2024

Looks like it's because this job is testing against stdlib distutils and not vendored distutils? What's the right path forward here?

Copy link
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution, @di!

I left some comments about the specific implementation.

Maybe @jaraco would like to have a look on the PR regarding the name normalisation?

@di
Copy link
Member Author

di commented Mar 21, 2024

@abravalheri Thanks! Everything is passing now.

@abravalheri abravalheri requested a review from jaraco April 4, 2024 09:12
@jaraco jaraco self-assigned this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Implement PEP 625 - File Name of a Source Distribution
4 participants