We need to be able to modify vistir to fix this bug, and we should work towards its complete removal. #5197
Conversation
…rk towards its complete removal.
| @@ -31,7 +31,7 @@ toml==0.10.2 | |||
| tomli==1.1.0 | |||
| tomlkit==0.9.2 | |||
| urllib3==1.26.6 | |||
| vistir==0.5.2 | |||
| vistir==0.5.2 # Deprecated: our copy is modified to fix bugs | |||
There was a problem hiding this comment.
we should try commenting this out entirely and see if vendoring still passes -- I think it won't though. Future vendoring would overwrite this bugfix. Maybe we should move vistir out of the vendor namespace and chip away at it from within pipenv module at same level as utils?
There was a problem hiding this comment.
If we can remove vistir completely, I will be extremely happy. But I am afraid it won't be so easy.
However, can you add a patch in the patches directory?
There was a problem hiding this comment.
I'd prefer to not patch it and move it out of vendor into a the level of utils so we can whack away at it.
There was a problem hiding this comment.
Or we just patch vistir and release a new version?
There was a problem hiding this comment.
Or -- I just got access to all of https://github.com/sarugaku so I can upstream this as well.
There was a problem hiding this comment.
That's what I meant. I wrote uranusjar today and he was very quick to respond.
|
This is resolved by this PR: #5199 |
The issue
Vistir has broken distutil code and probably other bugs. Fix the known bug here, and note in the vendoring that its deprecated and our copy has diverged from the parent pypi
vistir-- our goal is complete removal of this library. An effort will be made to begin converting usages inrequirementslibsince that will be the biggest blocker to completely removing it frompipenv.