minimum set of changes for using internal vendor pip. #5193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Declining in favor of branch based on this one that also had to vendor in pip 22.2 to get this last failing test passing: #5196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
The issue
I noticed this through a number of issue reports that sometimes a user's local pip conflicts with pipenv's expected behavior. To me, it does not make sense that we do not always use our patched vendored pip to install certain types of packages. With this change it should be possible for a user to only install
pipenvand not have pip installed at all. There is nothing wrong with having both installed, but why havepipenvrequire it and rely on it when we go to the work to patch an vendor in the latest and greatestpip?I will rename
notpiptopipin a follow-up PR.