Vendoring improvements #5182
Merged
Vendoring improvements #5182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are no longer vendoring this library.
We no longer use crayons, and it is abandoned upstread too.
We no longer vendor this package
oz123
added
the
Status: Deferred / On Hold 🛑
This seems like it was accidentally committed.
oz123
force-pushed
the
vendoring-improvements
branch
from
30b1b90 to
29ce818
Compare
We don't use this yaml import (only used for conda file parsing). Hence, we can remove this.
This was only used by dparse
The library includes a copy of MIT license with the source code.
We no longer need a copy of yaml in yaml3 since we apply a patch to dparse to disable a top level import of yaml.
This seems fixed in version 0.9.1 See here: https://github.com/sdispater/tomlkit/blob/f8099e6d6cb68bd0e7676252d7c379dc4d49b982/tomlkit/items.py#L168 Bump vendored version of tomlkit
Used: python -m invoke vendoring.update --package=tomlkit
oz123
removed
the
Status: Deferred / On Hold 🛑
This is really not needed anymore. k# Your branch is up to date with 'origin/vendoring-improvements'.
Might work on this later...
This reverts commit 506f102.
matteius
reviewed
Jul 26, 2022
matteius
reviewed
Jul 26, 2022
As discussed in the review, pip-shims of specifying what the pip module is.
matteius
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the cleaning of vendored package.
Additionally, it minor changes to the vendoring script itself (mostly minor cleanup related to Python2 and legacy backports).