Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable these tests again on the Windows CI. #5163

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Reenable these tests again on the Windows CI. #5163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4a3c75
attempt to reenable these tests on the CI.
matteius Jul 6, 2022
f1470f5
Add news fragment.
matteius Jul 6, 2022
20f4f52
Add news back to ignore path.
matteius Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ concurrency:
on:
push:
paths-ignore:
- "news/**"
- "examples/**"
- "peeps/**"
- "*.ini"
Expand Down
1 change: 1 addition & 0 deletions news/5064.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Re-enabled three installs tests again on the Windows CI as recent refactor work has fixed them.
3 changes: 0 additions & 3 deletions tests/integration/test_install_uri.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ def test_local_vcs_urls_work(PipenvInstance, tmpdir):
@pytest.mark.urls
@pytest.mark.install
@pytest.mark.needs_internet
@pytest.mark.skip_windows # FIXME: https://github.com/pypa/pipenv/issues/5064
def test_editable_vcs_install(PipenvInstance_NoPyPI):
with PipenvInstance_NoPyPI(chdir=True) as p:
c = p.pipenv(
Expand All @@ -147,7 +146,6 @@ def test_editable_vcs_install(PipenvInstance_NoPyPI):
@pytest.mark.urls
@pytest.mark.install
@pytest.mark.needs_internet
@pytest.mark.skip_windows # FIXME: https://github.com/pypa/pipenv/issues/5064
def test_install_editable_git_tag(PipenvInstance_NoPyPI):
# This uses the real PyPI since we need Internet to access the Git
# dependency anyway.
Expand Down Expand Up @@ -242,7 +240,6 @@ def test_install_local_vcs_not_in_lockfile(PipenvInstance):
@pytest.mark.urls
@pytest.mark.install
@pytest.mark.needs_internet
@pytest.mark.skip_windows # FIXME: https://github.com/pypa/pipenv/issues/5064
def test_get_vcs_refs(PipenvInstance_NoPyPI):
with PipenvInstance_NoPyPI(chdir=True) as p:
c = p.pipenv(
Expand Down