Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback pipenv run behavior to before 2021.11.5 on Windows #4937

Closed
wants to merge 5 commits into from
Closed

rollback pipenv run behavior to before 2021.11.5 on Windows #4937

wants to merge 5 commits into from

Conversation

pinfort
Copy link
Contributor

@pinfort pinfort commented Jan 29, 2022

The issue

Fixes #4935

The fix

We have two options about this issue.

  • disable windows_expand_args for avoid exception.
    • If you disable this, you will not be able to expand the arguments on Windows. However, this is the same behavior as before version 2021.11.5.
    • This PR provides this solution.
  • report this issue to upstream project and continue to use windows_expand_args feature.
    • If you select this choice, please close this PR.
    • Upstream project may not be consider this issue a problem.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@oz123 oz123 closed this in b60d37a Jan 30, 2022
@oz123
Copy link
Contributor

oz123 commented Jan 30, 2022

@pinfort thank you for your contributions! I merged all your commits in a single commit.
If you have multiple commits which are small, you can in the future squash them with git rebase -i HEAD~<n commits>.

@pinfort pinfort deleted the feature/disable-windows_expand_args branch January 31, 2022 01:54
@pinfort
Copy link
Contributor Author

pinfort commented Jan 31, 2022

@oz123 Thank you! I'll do that in the next 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running script with pipenv run will fail if args contains special characters on Windows
2 participants