Re-add support for deprecated PEP-345 markers #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packaging.markers did not support the same environment markers that PEP 345 specified, and they are still in use. Closes pypa#70
s-t-e-v-e-n-k
force-pushed
the
pep-345-markers
branch
from
4810613 to
634e38a
Compare
|
Shouldn't a deprecation warning be added (even for several years) ? Or do we expect PEP345 to be supported forever ? |
|
They'll probably be supported forever. They don't take much to support and the problem with dropping support is you can't go back in time and change it so that "foobar 1.0" which was released using them no longer uses them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packaging.markers did not support the same environment markers that
PEP 345 specified, and they are still in use.
Closes #70
A release when this merges would be lovely.