Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Appveyor errors #403

Merged
merged 11 commits into from
Jul 17, 2020
Merged

Debug Appveyor errors #403

merged 11 commits into from
Jul 17, 2020

Conversation

joerick
Copy link
Contributor

@joerick joerick commented Jul 12, 2020

No description provided.

@joerick
Copy link
Contributor Author

joerick commented Jul 17, 2020

Turns out the Appveyor PATH variable was highlighting a particularly fiddly bug in our environment variable handling. Backslashes in variables (very common in Windows paths) were able to 'escape' the outer quote. The new solution in bashlex_eval.py certainly smells better, and I've added a unit test to test the new solution to its limits :)

@joerick joerick marked this pull request as ready for review July 17, 2020 08:44
@YannickJadoul
Copy link
Member

Wow, sounds like a horrible bug! Kudos for catching that! :-)

So, context.input does not contain the same as node.word, then? But part.pos still indexes into context.input and not into node.word? That seems quite counterintuitive.

@joerick
Copy link
Contributor Author

joerick commented Jul 17, 2020

So, context.input does not contain the same as node.word, then? But part.pos still indexes into context.input and not into node.word? That seems quite counterintuitive.

Yep! The indexes refer to the input string, but node.word is the token that the lexer found. I think. Anyway, it seems to work!

Copy link
Member

@YannickJadoul YannickJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, better get this in, then?

@joerick joerick merged commit acf6036 into master Jul 17, 2020
@joerick joerick deleted the appveyor-debug-env branch August 29, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants