Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS support on AppVeyor #230

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Add macOS support on AppVeyor #230

merged 1 commit into from
Mar 7, 2020

Conversation

YannickJadoul
Copy link
Member

Stealing @mayeut's branch that was mentioned in #225; curious to see if it now works :-)

@YannickJadoul
Copy link
Member Author

Hmmm, not working yet, it seems, but macOS is available now.

@mayeut, do you know what to do? Or if you don't have time, do you mind if I push to your branch?

@mayeut
Copy link
Member

mayeut commented Nov 28, 2019

@mayeut, do you know what to do? Or if you don't have time, do you mind if I push to your branch?

I don't really know what to do about this SSL error on macOS...
You can push to this branch if you want to. Let's just not rebase/force-push anything just yet if we'll both be using it at some point.

@mayeut
Copy link
Member

mayeut commented Nov 28, 2019

Seems there are some issues with python on macOS:
appveyor/ci#3213

@YannickJadoul
Copy link
Member Author

Seems there are some issues with python on macOS:
appveyor/ci#3213

Argh. Guess we'll just have to wait for that to get fixed, then?

@mayeut mayeut force-pushed the macos-appveyor branch 2 times, most recently from 9fe01b6 to 335acb8 Compare December 26, 2019 15:10
@joerick joerick mentioned this pull request Jan 28, 2020
Merged
@mayeut mayeut force-pushed the macos-appveyor branch 3 times, most recently from a9d9e56 to 3ce8da8 Compare February 20, 2020 20:41
@mayeut mayeut force-pushed the macos-appveyor branch 2 times, most recently from 48c89ed to 3a8af7d Compare February 27, 2020 20:47
@mayeut mayeut mentioned this pull request Feb 29, 2020
Closed
@mayeut mayeut force-pushed the macos-appveyor branch 2 times, most recently from 0226da1 to 867d0d4 Compare March 7, 2020 10:20
@mayeut mayeut requested a review from joerick March 7, 2020 10:21
@mayeut
Copy link
Member

mayeut commented Mar 7, 2020

@YannickJadoul, @joerick,

I think it's ready to merge !

AppVeyor fixed there issues on macOS and I updated the docs & examples (unless I missed something else in the docs).

joerick
joerick approved these changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Lets see if it builds, then we can get this in :)

@joerick joerick merged commit 696067f into pypa:master Mar 7, 2020
@mayeut mayeut deleted the macos-appveyor branch March 7, 2020 15:13
@mayeut mayeut mentioned this pull request Mar 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerick joerick joerick approved these changes

@mayeut mayeut mayeut left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YannickJadoul @mayeut @joerick