-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building iOS wheels. #2286
Open
freakboy3742
wants to merge
14
commits into
pypa:main
Choose a base branch
from
freakboy3742:ios-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
acf4eb2
Add support for building iOS wheels.
freakboy3742 e992cef
Replace use of system() in test binary module.
freakboy3742 a450fba
Restored the 'minimal' approach of the minimal examples.
freakboy3742 ac8ab09
Split out platform details into standalone pages, and expand iOS plat…
freakboy3742 254b909
More doc corrections.
freakboy3742 a7a7b67
Merge branch 'main' into ios-support
freakboy3742 cead9fb
Bump support package to include fix for python/cpython#130292
freakboy3742 7b8b31e
Ensure iOS tests are all run on the same xdist worker.
freakboy3742 9c495a8
More iOS documentation tweaks.
freakboy3742 b622638
Merge branch 'main' into ios-support
freakboy3742 457d46a
Factor out common xcode version test utility.
freakboy3742 05ac4ae
Simplify iOS to a single platform with an expanded interpretation of …
freakboy3742 3b37676
I guess I should update the iOS tests as well...
freakboy3742 32b9203
Additional safety for missing iOS test output.
freakboy3742 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,12 +41,15 @@ | |
sys.executable, | ||
"-m", | ||
"pytest", | ||
"--dist", | ||
"loadgroup", | ||
f"--numprocesses={args.num_processes}", | ||
"-x", | ||
"--durations", | ||
"0", | ||
"--timeout=2400", | ||
"test", | ||
"-vv", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This generates a lot more output - but when a test fails, it helps to have as much context as possible. It was difficult to diagnose some of the iOS failures with the low verbosity output. |
||
] | ||
|
||
if sys.platform.startswith("linux") and args.run_podman: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows the build to run all the iOS tests on the same machine; see the iOS tests for the reason.