Skip to content

add missing addShows template #4564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 5, 2018
Merged

add missing addShows template #4564

merged 9 commits into from
Jul 5, 2018

Conversation

OmgImAlexis
Copy link
Collaborator

Missed adding this back in the last vue PR.

@OmgImAlexis OmgImAlexis added Bug Concluded Needs test (Vue) Needs tests added for this change (Vue) labels Jul 5, 2018
@OmgImAlexis OmgImAlexis added this to the 0.2.7 milestone Jul 5, 2018
@OmgImAlexis OmgImAlexis removed the Needs test (Vue) Needs tests added for this change (Vue) label Jul 5, 2018
@sharkykh
Copy link
Contributor

sharkykh commented Jul 5, 2018

Looks like you're giving the gulp sync command way too much credit... 😅
My point is the files you renamed didn't get renamed in light and dark templates, just got duped.
Also with the previous PR you needed to edit the handler in the Python code. Don't you need to do that here? Pretty sure it won't work without that change.

@sharkykh
Copy link
Contributor

sharkykh commented Jul 5, 2018 •
edited
Loading

Also need to fix /addRecommended (addRecommended.mako) with this PR.

@OmgImAlexis
Copy link
Collaborator Author

Looks like you're giving the gulp sync command way too much credit... 😅

What do you mean?

@sharkykh
Copy link
Contributor

sharkykh commented Jul 5, 2018

What do you mean?

I mean that it's not that smart.
If you rename or remove a file you need to manually do that for the dark and light themes.
As I said -

the files you renamed didn't get renamed in light and dark templates, just got duped.

image

@sharkykh
Copy link
Contributor

sharkykh commented Jul 5, 2018

Also:

image
image

sharkykh
sharkykh suggested changes Jul 5, 2018
View reviewed changes
themes-default/slim/static/js/templates/add-recommended.vue Outdated
@@ -1,6 +1,5 @@
<template>
<div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you don't need that wrapper div :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, it's okay, can be removed.
Keep the <div id="addShowPortal"> though.

themes-default/slim/static/js/templates/add-shows.vue Outdated
@@ -1,6 +1,5 @@
<template>
<div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

@OmgImAlexis OmgImAlexis merged commit 0b76c34 into develop Jul 5, 2018
@OmgImAlexis OmgImAlexis deleted the bugfix/addShows-missing-template branch July 5, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkykh sharkykh sharkykh approved these changes

Assignees
No one assigned
Labels
Bug Concluded
Projects
None yet
Milestone
0.2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@OmgImAlexis @sharkykh