Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vueify footer #4520

Merged
merged 6 commits into from
Jun 16, 2019
Merged

Vueify footer #4520

merged 6 commits into from
Jun 16, 2019

Conversation

sharkykh
Copy link
Contributor

@sharkykh sharkykh commented Jul 2, 2018

Converts footer to a Vue SFC

@sharkykh sharkykh self-assigned this Jul 2, 2018
@OmgImAlexis OmgImAlexis mentioned this pull request Jul 2, 2018
@OmgImAlexis OmgImAlexis self-requested a review July 2, 2018 08:35
@OmgImAlexis OmgImAlexis added this to the 0.2.7 milestone Jul 2, 2018
@OmgImAlexis OmgImAlexis added the Needs test (Vue) Needs tests added for this change (Vue) label Jul 5, 2018
@OmgImAlexis

This comment has been minimized.

@sharkykh sharkykh modified the milestones: 0.2.7, 0.2.8 Jul 14, 2018
@sharkykh sharkykh changed the title Vueify/footer (+ scroll buttons) Vueify footer Jul 14, 2018
@sharkykh sharkykh force-pushed the vueify/footer branch 2 times, most recently from 44b63fe to 5b93553 Compare July 25, 2018 12:26
@sharkykh

This comment has been minimized.

@sharkykh sharkykh modified the milestones: 0.2.9, 0.2.10 Aug 10, 2018
@sharkykh sharkykh modified the milestones: 0.2.11, backlog Sep 18, 2018
@sharkykh sharkykh mentioned this pull request Jun 9, 2019
2 tasks
@sharkykh sharkykh force-pushed the vueify/footer branch 2 times, most recently from 89e1ffc to 7821701 Compare June 10, 2019 19:15
@sharkykh sharkykh added Concluded On hold and removed Needs test (Vue) Needs tests added for this change (Vue) labels Jun 10, 2019
@sharkykh

This comment has been minimized.

@sharkykh sharkykh removed the request for review from OmgImAlexis June 10, 2019 19:20
@sharkykh sharkykh modified the milestones: backlog, 0.3.3, 0.3.4 Jun 10, 2019
@medariox medariox modified the milestones: 0.3.4, 0.3.5 Jun 13, 2019
@@ -102,7 +102,7 @@ def packages():
},
cmdclass={'test': PyTest},
tests_require=tests_runtime_require + [
'flake8>=3.5.0',
'flake8>=3.7.7',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 3.7.0 added native support for per-file-ignores.
http://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-per-file-ignores

sharkykh added 4 commits June 13, 2019 20:55

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
sharkykh added 2 commits June 16, 2019 10:52

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
Copy link
Contributor

@p0psicles p0psicles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@medariox medariox merged commit a551865 into develop Jun 16, 2019
@medariox medariox deleted the vueify/footer branch June 16, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants