Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transformations for Discrete distributions #314

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

Sayam753
Copy link
Member

@Sayam753 Sayam753 commented Aug 23, 2020

As per discussions in #306 and PyMC3's Discrete distribution, this PR reverts the addition of transformations to Discrete distributions from #289.

cc @junpenglao

@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #314 into master will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   90.08%   90.09%           
=======================================
  Files          33       33           
  Lines        2462     2453    -9     
=======================================
- Hits         2218     2210    -8     
+ Misses        244      243    -1     
Impacted Files Coverage Δ
pymc4/distributions/discrete.py 98.23% <ø> (-0.08%) ⬇️
pymc4/distributions/distribution.py 88.48% <75.00%> (+0.31%) ⬆️

@junpenglao
Copy link
Member

Thanks!

@junpenglao junpenglao merged commit 79d55af into pymc-devs:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants