MAINT: Lint html #1021
MAINT: Lint html #1021
Conversation
| <a class="theme-switch" data-mode="dark"><i class="fa-regular fa-moon"></i></a> | ||
| <a class="theme-switch" data-mode="auto"><i class="fa-solid fa-circle-half-stroke"></i></a> | ||
| </span> | ||
| <button class="theme-switch-button btn btn-sm btn-outline-primary navbar-btn rounded-circle" title="{{ _('light/dark') }}" aria-label="{{ _('light/dark') }}" data-toggle="tooltip"> |
There was a problem hiding this comment.
Didn't this span -> button change get merged already? We should double check that we are doing this from the latest commit
There was a problem hiding this comment.
I started this PR before the merge of #1050. when I merged it back in the line has been analyzed as a change (with the linting)
| {%- endblock body_tag %} | ||
| <body data-spy="scroll" data-target="#bd-toc-nav" data-offset="180" data-default-mode="{{ default_mode }}"> | ||
|
|
||
| {# A button hidden by default to help assistive devices quickly jump to main content #} |
There was a problem hiding this comment.
same here - this seems like it's being added even though this was already merged into main
|
If you don't think this changes anything problematic then I think we should just merge it in because it'll become out of date quickly, what do you think? |
|
I'd like to prevent any merge before release of 0.12.0 but I would be ok straight after it |
|
as I worried, this one is now out of date :-) want to resolve the conflicts and then we can merge quickly? |
|
there's a linting issue that is solved in #1070. Whenever it's merged, we can merge this one |
|
alright let's merge this so that we can see how it feels in practice! |
I found djlint, a html linter compatible with jinja.
In this PR I added some parameters, add the test in the pre-commits and run djlint on the whole html files.