the theme does not provide placement for the ethical ads of readthedoc

[12rambau]

I know we all hate ads, but at the same time we all love the possibility to use the readTheDoc server free of charge to serve our documentations.

When I run my documentation in readthedoc I don't see the ethical ads (usually digital ocean for me).

The js console confirms :

Possible Unhandled Promise Rejection:
Error: No ad placements found.

in ethicalads.min.js:201

Will you consider adding it ?

[bollwyvl]

A lot of sites using this theme self-host, so i guess this hasn't come up. However, we do host this repo's example site there, so it would be reasonable to give something back.

The quickest win would be to add an example of the markup needed in a custom template... this would likely have legs beyond hard-coding something for that particular host and that particular ad provider. Would you happen to know what we need to do?

[12rambau]

Would you happen to know what we need to do?

no but I will dig ;-)

[choldgraf]

I think that we need to add this snippet of HTML somewhere on the page:

https://github.com/pradyunsg/furo/blob/main/src/furo/theme/furo/sidebar/ethical-ads.html

[12rambau]

I saw this morning that the add are now displayed in the side bar of readthedoc, Did someone changed anything here or is it related to RDT ?

[choldgraf]

Ah yes! We added it in #355 🎉