Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "readthedocs" ad placement explicitly #169

Closed
choldgraf opened this issue Aug 9, 2020 · 5 comments · Fixed by #677
Closed

Set "readthedocs" ad placement explicitly #169

choldgraf opened this issue Aug 9, 2020 · 5 comments · Fixed by #677
Labels
enhancement New feature or request

Comments

@choldgraf
Copy link
Member

choldgraf commented Aug 9, 2020

Right now, if people host their documentation on readthedocs, it will automatically put an advertisement at the bottom of the page:

image

It's not too obtrusive, though it clashes a bit with our CSS and overlaps with some elements.

I believe that we can include some HTML that will instead tell RTD to put the add there instead of at the bottom, and so we can control how it looks etc a bit better. What do folks think about that?

I believe we need to add: https://github.com/pradyunsg/furo/blob/main/src/furo/theme/furo/sidebar/ethical-ads.html?rgh-link-date=2021-03-20T19%3A15%3A02Z

@choldgraf choldgraf added the enhancement New feature or request label Aug 9, 2020
@chrisjsewell
Copy link
Member

While your mentioning RTD, I would also link pydata/pydata-sphinx-theme#194

@12rambau
Copy link

@chrisjsewell I've actually open an issue for this very purpose: pydata/pydata-sphinx-theme#345

I'm just jumping here, Ware there any evolution on this matter since August ?

@choldgraf
Copy link
Member Author

@12rambau nope - we'd still like it to happen - if anyone would like to give a shot at a PR I am happy to review!

@12rambau
Copy link

12rambau commented Mar 22, 2021

I was looking on how you handling the ad placement in RDT and Google lead me here but I think I'm actually off-topic

if anyone would like to give a shot at a PR I am happy to review!

If only, I was good enough in HTML/CSS 😄

@choldgraf
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants