Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart_holder] smart_holder / master benchmarking 2025-02-16 #5529

Draft
wants to merge 1 commit into
base: smart_holder
Choose a base branch
from

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Feb 17, 2025

Description

NOT FOR MERGING

This PR simply removes smart_holder tests so that

  • tests/CMakeLists.txt is identical to master

while the code under

  • include/pybind11 is exactly as under the current smart_holder branch.

This was used to collect the measurements shown in the

The results in a nutshell:

  • .so sizes of extension modules are expected to be <3% larger (smart_holder / master).
  • Compile and link times are expected to be <2% larger.
  • Run times are expected to be practically identical (based on pytest execution times).

Note that these are not micro benchmarks, but assumed to reflect real-life situations.

For easy future reference:

Suggested changelog entry:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant