PyPy 3.11 does not implement Py_TPFLAGS_MANAGED_DICT #5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
reviewed
Feb 2, 2025
include/pybind11/detail/class.h
Outdated
| @@ -574,7 +574,7 @@ extern "C" inline int pybind11_clear(PyObject *self) { | |||
| inline void enable_dynamic_attributes(PyHeapTypeObject *heap_type) { | |||
| auto *type = &heap_type->ht_type; | |||
| type->tp_flags |= Py_TPFLAGS_HAVE_GC; | |||
| #if PY_VERSION_HEX < 0x030B0000 | |||
| #if PY_VERSION_HEX < 0x030B0000 || defined(PYPY_VERSION) | |||
There was a problem hiding this comment.
Could you please add a simple comment, e.g.
#if PY_VERSION_HEX < 0x030B0000 || defined(PYPY_VERSION) // For PyPy see PR #5508
rwgk
approved these changes
Feb 2, 2025
|
The CI / 🐍 graalpy-24.1 • macos-13 • x64 failure is definitely unrelated. @msimacek FYI: I've seen that test flaking a few times in the past ~week. It made me wonder, has something changed recently? |
|
@msimacek CI / 🐍 graalpy-24.1 • macos-13 • x64 failed again. I'm still certain it's unrelated to this PR, but the likelihood of these failures is definitely up by a lot recently. I'll go ahead with merging this PR. |
|
Thanks! |
mgorny
added a commit
to mgorny/pybind11
that referenced
this pull request
Feb 20, 2025
Adjust the `Py_TPFLAGS_MANAGED_DICT` logic in `include/pybind11/attr.h` to match the one used in `include/pybind11/detail/class.h`. This is a followup to pybind#5508.
henryiii
pushed a commit
that referenced
this pull request
Feb 20, 2025
* Sync `Py_TPFLAGS_MANAGED_DICT` for PyPy3.11 across the codebase Adjust the `Py_TPFLAGS_MANAGED_DICT` logic in `include/pybind11/attr.h` to match the one used in `include/pybind11/detail/class.h`. This is a followup to #5508. * Use a common `#define` for pre-`Py_TPFLAGS_MANAGED_DICT` Pythons * style: pre-commit fixes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PyPy support for Python 3.11 is almost ready for release. The new
Py_TPFLAGS_MANAGED_DICTis an implementation detail, and PyPy has not yet implemented support for it, see pypy/pypy#5125. I am testing pybind11 via a weekly cron job and noticed the failure there. Where would be a good place to add a CI run of PyPy 3.11, which has not been released yet, here?Suggested changelog entry: