Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ODR voilations #5387

Closed
wants to merge 1 commit into from
Closed

Fix ODR voilations #5387

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Sep 29, 2024 •
edited
Loading

Description

To eliminate ORD violations.

@cyyever cyyever changed the title Fix ODR by making them inline Fix ODR voilations Sep 29, 2024
@rwgk
Copy link
Collaborator

rwgk commented Sep 29, 2024

In class scope, inline are implicit:

https://en.cppreference.com/w/cpp/language/inline#:~:text=A%20function%20defined%20entirely%20inside,(since%20C%2B%2B20).

I.e. there are no ODR violations here.

I'm not aware of any significant project in which inline are specified redundantly. (It's just noise IMO.)

@rwgk rwgk closed this Sep 29, 2024
@cyyever cyyever deleted the fix_odr branch September 30, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyyever @rwgk