[smart_holder] git merge master #5349

rwgk · 2024-09-02T17:30:12Z

Description

Helper/scratch PR for testing.

Piggy-backed:

--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -13,7 +13,7 @@ on:
 permissions: read-all

 concurrency:
-  group: test-sh-avl${{ github.ref }}
+  group: test-${{ github.ref }}
   cancel-in-progress: true

 env:

Suggested changelog entry:

…thon buffer from wrapped object (pybind#5324) * Add test for throwing def_buffer case * Translate C++ -> Python exceptions in buffer creation This required a little refactoring to extract exception translation to a separate method * Fix code formatting * Fix "unused parameter" warning * Refactor per review * style: pre-commit fixes * Address review comments * Address review comments --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…schke

…schke for catching this)

@rhaschke

…nks @rhaschke for catching this)" This reverts commit 4cc11dc.

[pybind/pybind11] CI workflow run CI: No jobs were run

…rhaschke

…rhaschke for helping)

vnlitvinov and others added 7 commits September 2, 2024 09:01

Merge branch 'master' into sh_merge_master

e5f57c4

Remove stray `concurrency: group: test-${{ github.ref }} (thanks @rha…

4cc11dc

…schke for catching this)

Revert "Remove stray `concurrency: group: test-${{ github.ref }} (tha…

f0d2da3

…nks @rhaschke for catching this)" This reverts commit 4cc11dc.

Without the group this happened:

c31e79a

[pybind/pybind11] CI workflow run CI: No jobs were run

Remove suffix in `concurrency: group: test-${{ github.ref }} (thanks @…

53579b4

…rhaschke for helping)

gee, sorry, managed to confuse myself

a05a201

rwgk merged commit a05a201 into pybind:smart_holder Sep 2, 2024
80 checks passed

github-actions bot added the needs changelog Possibly needs a changelog entry label Sep 2, 2024

rwgk deleted the sh_merge_master branch September 2, 2024 18:47

rwgk removed the needs changelog Possibly needs a changelog entry label Sep 2, 2024

rwgk pushed a commit to rwgk/pybind11 that referenced this pull request Sep 2, 2024

Apply ci.yml diff piggy-backed in pybind#5349

1baa98b

rwgk mentioned this pull request Sep 2, 2024

[Preview 3] Merge smart_holder into master (squash merge) #5339

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[smart_holder] git merge master #5349

[smart_holder] git merge master #5349

rwgk commented Sep 2, 2024 •

edited

Loading

[smart_holder] git merge master #5349

[smart_holder] git merge master #5349

Conversation

rwgk commented Sep 2, 2024 • edited Loading

Description

Suggested changelog entry:

rwgk commented Sep 2, 2024 •

edited

Loading