Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributor and review data #434

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Update contributor and review data #434

merged 1 commit into from
Jul 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 2, 2024

Automated changes by create-pull-request GitHub action

@lwasser lwasser added the DO-NOT-MERGE A caution that a PR is not ready to be merged label Jul 2, 2024
@sneakers-the-rat
Copy link
Contributor

Seems bad to delete all the packages lol

@lwasser
Copy link
Member

lwasser commented Jul 3, 2024

@sneakers-the-rat there are two issues!
the blank file is fixed here: pyOpenSci/pyosMeta#172 we updated the label names! easy.
but also it's still failing because we have a new reviewer format. instead of using

reviewer_1 and reviewer_2 we are moving to a

reviewers element in our package yaml generation / pydantic model.

So i think we need to

  1. clean up the code to ensure it parses the reviewer field correctly (maybe this is needed)
  2. create a validator that will ingest both reviews with reviewer_1, _2 or 3 OR the new format which is reviewers: list of reviewer github handles here.

If you have any bandwidth to work on a pydantic validator in our pyos meta package please lemme know. but otherwise i'm gonna try to fix it :upside. lessons learned to open issues immediately when we update the review template and / or labels!!

@sneakers-the-rat
Copy link
Contributor

here's my take: pyOpenSci/pyosMeta#174

@lwasser
Copy link
Member

lwasser commented Jul 4, 2024

i am going to merge this! i suspect the date inconsistencies will cause a jekyll issue but let's see.

@lwasser lwasser merged commit 3061bbe into main Jul 4, 2024
3 checks passed
@lwasser lwasser deleted the contribs branch July 4, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO-NOT-MERGE A caution that a PR is not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants