Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vasilis/dmlcoef #283

Merged
merged 8 commits into from
Sep 16, 2020
Merged

Vasilis/dmlcoef #283

merged 8 commits into from
Sep 16, 2020

Conversation

vsyrgkanis
Copy link
Collaborator

Added coef_ and intercept_ to DMLCateEstimator. This can also enable bootstrap inference of the coef and the intercept.

@ghost
Copy link

ghost commented Sep 10, 2020

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks straightforward, but the test_cate_api test is now failing because an output shape is unexpected - can you investigate why this might be the case?

vsyrgkanis and others added 5 commits September 10, 2020 14:02
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
@vsyrgkanis vsyrgkanis merged commit 949c246 into master Sep 16, 2020
@vsyrgkanis vsyrgkanis deleted the vasilis/dmlcoef branch November 16, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants