Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vasilis/drlearner #137

Merged
merged 51 commits into from
Nov 11, 2019
Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
f31d86a
separating drlearner
vasilismsr Nov 6, 2019
7c4d76d
better docstring
vasilismsr Nov 6, 2019
6e2c972
notebook
vasilismsr Nov 6, 2019
b9d5238
drlearner documentation finalized.
vasilismsr Nov 6, 2019
ad72eab
removed doubly robust learner from metalearners
vasilismsr Nov 6, 2019
868b5c1
revmoed drlearner test from metalearners and started new test file fo…
vasilismsr Nov 6, 2019
a293f0f
revmoed drlearner test from metalearners and started new test file fo…
vasilismsr Nov 6, 2019
c63d6b3
changed tests in dml to adhere to the CATE API. Some calls to effect …
vasilismsr Nov 6, 2019
d2494b6
added exhaustive tests for drlearner. Fixed bugs from corner cases
vasilismsr Nov 7, 2019
e75fd48
bug in docstring regarding how split is called to generate crossfit f…
vasilismsr Nov 7, 2019
fbc3f1d
changed bootstarp tests to conform with keyword only effect and effec…
vasilismsr Nov 7, 2019
3397d95
bootstrap tests, fixing bugs related to positional arguments T0, T1
vasilismsr Nov 7, 2019
b13581e
linting
vasilismsr Nov 7, 2019
e4c355d
more tests for drlearner and small bugs
vasilismsr Nov 7, 2019
8611577
reverted back to coef_ and intercept_. Fixed docstring. Added exhaust…
vasilismsr Nov 7, 2019
0dcea06
added checks of fitted dims for W and Z during scoring in _OrthoLearn…
vasilismsr Nov 7, 2019
7c55fb0
testing notebook
vasilismsr Nov 7, 2019
b5c0a07
linting
vasilismsr Nov 7, 2019
59d9fb1
docstring fix regarding n_splits in multiple places. Fixed notebook f…
vasilismsr Nov 7, 2019
d3274ff
changed statsmodels inference inptu properties to reflect that we onl…
vasilismsr Nov 7, 2019
988c53d
small change in test drlearner
vasilismsr Nov 7, 2019
e48f7de
docstring for linear drlearner
vasilismsr Nov 7, 2019
95fa08f
improved example in docstring of lineardrlearner
vasilismsr Nov 7, 2019
ef0dff5
adding more slacks to some drlearner coverage tests
vasilismsr Nov 7, 2019
07a79e2
Merge branch 'master' into vasilis/drlearner
vasilismsr Nov 7, 2019
d2b7835
linting
vasilismsr Nov 7, 2019
0474015
linting
vasilismsr Nov 7, 2019
f6d1505
removed OrthoLearner testing notebook
vasilismsr Nov 7, 2019
cb60dc4
comments on fit score dimension mismatch
vasilismsr Nov 8, 2019
9768a76
removed leftover print statement from cate estimator
vasilismsr Nov 8, 2019
c315539
replaced :code: with
vasilismsr Nov 8, 2019
51e0595
added :meth:
vasilismsr Nov 8, 2019
f377e95
added :meth:
vasilismsr Nov 8, 2019
aa21807
removed + for string concat
vasilismsr Nov 8, 2019
a3b7b52
removed redundant test code
vasilismsr Nov 8, 2019
b00052c
added comment on overlapping tests between DML and DRLearner
vasilismsr Nov 8, 2019
cd597f4
removed redundant rand_sol code in test_drlearner
vasilismsr Nov 8, 2019
42fae99
removed + operator for string concat
vasilismsr Nov 8, 2019
8de555b
added TODO for allowing for 2d y of shape (n,1) and also added test t…
vasilismsr Nov 8, 2019
084561d
removed redundant adding and subtracting in statsmodelscateestimator
vasilismsr Nov 8, 2019
d606f2a
changed :attr: to :meth:
vasilismsr Nov 8, 2019
7803c2e
added TODO so that we merge functionality between statsmodelsinferenc…
vasilismsr Nov 8, 2019
610db58
replaced printing with subTests
vasilismsr Nov 8, 2019
68d5180
linting
vasilismsr Nov 8, 2019
fdd536a
fixed docstring in dml. Added utility function of inverse_onehot enco…
vasilismsr Nov 9, 2019
bfb1ff8
removed replacing None weights with np.ones in drlearner scoring sinc…
vasilismsr Nov 9, 2019
179c2cf
typo in error mst
vasilismsr Nov 9, 2019
9c4271e
made statsmodelslinearregression be child of BaseEstimator
vasilismsr Nov 9, 2019
8ea37c8
added comment on code design choice in model_final of drlearner, rela…
vasilismsr Nov 9, 2019
36ddc55
put docstrings in methods and removed them from attributes
vasilismsr Nov 9, 2019
c1549c8
Merge branch 'master' into vasilis/drlearner
vasilismsr Nov 10, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into vasilis/drlearner
vasilismsr authored Nov 10, 2019

Verified

This commit was signed with the committer’s verified signature.
bbenzikry Beni Ben zikry
commit c1549c85a4217f4f08a65b45cd77b999e4c7a53b

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.