Pcm 1668 integration fixes #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 22, 2022 23:20
maxwellmooney13
requested review from
jensengar,
zservies and
djhouseknecht
as code owners
added 2 commits
March 24, 2022 13:45
jensengar
requested changes
Mar 24, 2022
| } else { | ||
| this.logger.info('Currently not in possession of the Call Lock; Cannot react to Device Actions') | ||
| } | ||
| this.callControl.releaseCallLock(); |
There was a problem hiding this comment.
this seems like this should be in the if block. I'd maybe rewrite this like this:
if (!this.callLock) {
return this.logger.info('Currently not in possession of the Call Lock; Cannot react to Device Actions');
}
this.callControl.ring(false);
this.callControl.releaseCallLock();
There was a problem hiding this comment.
also, does releaseCallLock need to be awaited?
There was a problem hiding this comment.
I think it would make the most sense to ensure it is done properly or if we get the right error message. But looking through their docs, they don't await any of the examples of releaseCallLock
added 3 commits
March 24, 2022 16:00
…lifting within headset library
jensengar
requested changes
Mar 25, 2022
| @@ -118,6 +126,16 @@ export default class HeadsetService { | |||
| return this.selectedImplementation.connect(micLabel); | |||
| } | |||
|
|
|||
| connectionStatus(): string { | |||
There was a problem hiding this comment.
indentation is off in this fn.
| this.callControl.offHook(false); | ||
| } else { | ||
| this.logger.info('Currently not in possession of the Call Lock; Cannot react to Device Actions') | ||
| if(!this.callLock) { |
| @@ -23,7 +23,7 @@ type Events = { | |||
| [HeadsetEvents.deviceRejectedCall]: RejectCallEventInfo; | |||
| [HeadsetEvents.loggableEvent]: EventInfo; | |||
| [HeadsetEvents.webHidPermissionRequested]: { callback: any }; | |||
| [HeadsetEvents.deviceConnectionStatusChanged]: { currentVendor: VendorImplementation, isConnected: boolean, isConnecting: boolean}; | |||
| [HeadsetEvents.deviceConnectionStatusChanged]: string; | |||
There was a problem hiding this comment.
This should be typed somehow. Maybe something like this:
export type DeviceConnectionStatus = 'connecting' | 'connected' | 'notConnected' | 'noVendor';
or whatever we settled on.
jensengar
approved these changes
Mar 25, 2022
| @@ -23,9 +23,11 @@ type Events = { | |||
| [HeadsetEvents.deviceRejectedCall]: RejectCallEventInfo; | |||
| [HeadsetEvents.loggableEvent]: EventInfo; | |||
| [HeadsetEvents.webHidPermissionRequested]: { callback: any }; | |||
| [HeadsetEvents.deviceConnectionStatusChanged]: { currentVendor: VendorImplementation, isConnected: boolean, isConnecting: boolean}; | |||
| [HeadsetEvents.deviceConnectionStatusChanged]: DeviceConnectionStatus; | |||
There was a problem hiding this comment.
Just a note to remember to update the SDK docs when you pull this new version in.
djhouseknecht
approved these changes
Mar 25, 2022
maxwellmooney13
added a commit
that referenced
this pull request
Mar 28, 2022
* PCM-1667 (#22) * PCM-1667 added in changes for retryConnection function * PCM-1667 added changelog and bumped version * PCM-1667 updated Jenkinsfile * PCM-1667 revert Jenkinsfile for now * PCM-1667 updated changelog with tags * PCM-1667 updated changelog Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira updated jenkinsfile (#23) * no-jira updated jenkinsfile * no-jira updating jsx flag in tsconfig * no-jira update jsx flag in tsconfig * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira updated jenkinsfile * no-jira updated jenkinsfile * no-jira reverted pipeline library used * no-jira updated jenkinsfile * no-jira updated .env file and Jenkinsfile * no-jira updated jenkinsfile and updated typescript version * no-jira updated unit test for utils.test.ts * no-jira reverted env file and put react-jsx as jsx value * no-jira changed testResults value * no-jira changed manifest back Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#25) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * PCM-1668 updated changelog * PCM-1668 updated changelog Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com>
maxwellmooney13
added a commit
that referenced
this pull request
Mar 30, 2022
* PCM-1667 (#22) * PCM-1667 added in changes for retryConnection function * PCM-1667 added changelog and bumped version * PCM-1667 updated Jenkinsfile * PCM-1667 revert Jenkinsfile for now * PCM-1667 updated changelog with tags * PCM-1667 updated changelog Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira updated jenkinsfile (#23) * no-jira updated jenkinsfile * no-jira updating jsx flag in tsconfig * no-jira update jsx flag in tsconfig * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira updated jenkinsfile * no-jira updated jenkinsfile * no-jira reverted pipeline library used * no-jira updated jenkinsfile * no-jira updated .env file and Jenkinsfile * no-jira updated jenkinsfile and updated typescript version * no-jira updated unit test for utils.test.ts * no-jira reverted env file and put react-jsx as jsx value * no-jira changed testResults value * no-jira changed manifest back Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#25) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#30) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump * PCM-1668 moved toLowercase to the library rather than consuming app; made change to test app to fix issue * no-jira added in snyk fixes * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * PCM-1668 updated changelog * PCM-1668 merge conflict Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com>
maxwellmooney13
added a commit
that referenced
this pull request
Apr 18, 2022
* PCM-1667 (#22) * PCM-1667 added in changes for retryConnection function * PCM-1667 added changelog and bumped version * PCM-1667 updated Jenkinsfile * PCM-1667 revert Jenkinsfile for now * PCM-1667 updated changelog with tags * PCM-1667 updated changelog Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira updated jenkinsfile (#23) * no-jira updated jenkinsfile * no-jira updating jsx flag in tsconfig * no-jira update jsx flag in tsconfig * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira updated jenkinsfile * no-jira updated jenkinsfile * no-jira reverted pipeline library used * no-jira updated jenkinsfile * no-jira updated .env file and Jenkinsfile * no-jira updated jenkinsfile and updated typescript version * no-jira updated unit test for utils.test.ts * no-jira reverted env file and put react-jsx as jsx value * no-jira changed testResults value * no-jira changed manifest back Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#25) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#30) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump * PCM-1668 moved toLowercase to the library rather than consuming app; made change to test app to fix issue * no-jira added in snyk fixes * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Updating to standard MIT license * Updating to standard MIT license * Integration fix (#36) * no-jira major version bump * 1.0.0 * no-jira fixed issue when no label is present; fixed unit tests; made SDK initialization more lazy * no-jira fixed issue when no label is present; fixed unit tests; made SDK initialization more lazy * no-jira version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira version 1.0.1 release Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> Co-authored-by: Genesys Developer Evangelists <developerevangelists@genesys.com>
maxwellmooney13
added a commit
that referenced
this pull request
May 25, 2022
* PCM-1667 (#22) * PCM-1667 added in changes for retryConnection function * PCM-1667 added changelog and bumped version * PCM-1667 updated Jenkinsfile * PCM-1667 revert Jenkinsfile for now * PCM-1667 updated changelog with tags * PCM-1667 updated changelog Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira updated jenkinsfile (#23) * no-jira updated jenkinsfile * no-jira updating jsx flag in tsconfig * no-jira update jsx flag in tsconfig * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira updated jenkinsfile * no-jira updated jenkinsfile * no-jira reverted pipeline library used * no-jira updated jenkinsfile * no-jira updated .env file and Jenkinsfile * no-jira updated jenkinsfile and updated typescript version * no-jira updated unit test for utils.test.ts * no-jira reverted env file and put react-jsx as jsx value * no-jira changed testResults value * no-jira changed manifest back Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#25) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#30) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump * PCM-1668 moved toLowercase to the library rather than consuming app; made change to test app to fix issue * no-jira added in snyk fixes * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Updating to standard MIT license * Updating to standard MIT license * Integration fix (#36) * no-jira major version bump * 1.0.0 * no-jira fixed issue when no label is present; fixed unit tests; made SDK initialization more lazy * no-jira fixed issue when no label is present; fixed unit tests; made SDK initialization more lazy * no-jira version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * [PCM-1903] add state management and fix typings * fix build artifact * various fixes for headset state and documentation * no-jira worked out issue with updating headset state through device changes (#44) Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira removed environments from deployConfig and autoSubmitCm from Jenkinsfile (#45) Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira merge conflict resolution Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> Co-authored-by: Genesys Developer Evangelists <developerevangelists@genesys.com> Co-authored-by: Garrett Jensen <garrett.jensen@genesys.com> Co-authored-by: Garrett Jensen <jensen.gar@gmail.com>
maxwellmooney13
added a commit
that referenced
this pull request
May 25, 2022
* Release/v0.1.1 (#24) * PCM-1667 (#22) * PCM-1667 added in changes for retryConnection function * PCM-1667 added changelog and bumped version * PCM-1667 updated Jenkinsfile * PCM-1667 revert Jenkinsfile for now * PCM-1667 updated changelog with tags * PCM-1667 updated changelog Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira updated jenkinsfile (#23) * no-jira updated jenkinsfile * no-jira updating jsx flag in tsconfig * no-jira update jsx flag in tsconfig * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira updated jenkinsfile * no-jira updated jenkinsfile * no-jira reverted pipeline library used * no-jira updated jenkinsfile * no-jira updated .env file and Jenkinsfile * no-jira updated jenkinsfile and updated typescript version * no-jira updated unit test for utils.test.ts * no-jira reverted env file and put react-jsx as jsx value * no-jira changed testResults value * no-jira changed manifest back Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Release/v0.1.2 (#28) * PCM-1667 (#22) * PCM-1667 added in changes for retryConnection function * PCM-1667 added changelog and bumped version * PCM-1667 updated Jenkinsfile * PCM-1667 revert Jenkinsfile for now * PCM-1667 updated changelog with tags * PCM-1667 updated changelog Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira updated jenkinsfile (#23) * no-jira updated jenkinsfile * no-jira updating jsx flag in tsconfig * no-jira update jsx flag in tsconfig * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira updated jenkinsfile * no-jira updated jenkinsfile * no-jira reverted pipeline library used * no-jira updated jenkinsfile * no-jira updated .env file and Jenkinsfile * no-jira updated jenkinsfile and updated typescript version * no-jira updated unit test for utils.test.ts * no-jira reverted env file and put react-jsx as jsx value * no-jira changed testResults value * no-jira changed manifest back Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#25) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * PCM-1668 updated changelog * PCM-1668 updated changelog Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * fix snyk config * Release/v0.1.3 (#32) * PCM-1667 (#22) * PCM-1667 added in changes for retryConnection function * PCM-1667 added changelog and bumped version * PCM-1667 updated Jenkinsfile * PCM-1667 revert Jenkinsfile for now * PCM-1667 updated changelog with tags * PCM-1667 updated changelog Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira updated jenkinsfile (#23) * no-jira updated jenkinsfile * no-jira updating jsx flag in tsconfig * no-jira update jsx flag in tsconfig * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira updated jenkinsfile * no-jira updated jenkinsfile * no-jira reverted pipeline library used * no-jira updated jenkinsfile * no-jira updated .env file and Jenkinsfile * no-jira updated jenkinsfile and updated typescript version * no-jira updated unit test for utils.test.ts * no-jira reverted env file and put react-jsx as jsx value * no-jira changed testResults value * no-jira changed manifest back Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#25) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#30) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump * PCM-1668 moved toLowercase to the library rather than consuming app; made change to test app to fix issue * no-jira added in snyk fixes * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * PCM-1668 updated changelog * PCM-1668 merge conflict Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira major version bump (#35) * no-jira major version bump * no-jira major version bump in package.json Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Release/v1.0.1 (#38) * PCM-1667 (#22) * PCM-1667 added in changes for retryConnection function * PCM-1667 added changelog and bumped version * PCM-1667 updated Jenkinsfile * PCM-1667 revert Jenkinsfile for now * PCM-1667 updated changelog with tags * PCM-1667 updated changelog Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira updated jenkinsfile (#23) * no-jira updated jenkinsfile * no-jira updating jsx flag in tsconfig * no-jira update jsx flag in tsconfig * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira updated jenkinsfile * no-jira updated jenkinsfile * no-jira reverted pipeline library used * no-jira updated jenkinsfile * no-jira updated .env file and Jenkinsfile * no-jira updated jenkinsfile and updated typescript version * no-jira updated unit test for utils.test.ts * no-jira reverted env file and put react-jsx as jsx value * no-jira changed testResults value * no-jira changed manifest back Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#25) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#30) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump * PCM-1668 moved toLowercase to the library rather than consuming app; made change to test app to fix issue * no-jira added in snyk fixes * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Updating to standard MIT license * Updating to standard MIT license * Integration fix (#36) * no-jira major version bump * 1.0.0 * no-jira fixed issue when no label is present; fixed unit tests; made SDK initialization more lazy * no-jira fixed issue when no label is present; fixed unit tests; made SDK initialization more lazy * no-jira version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira version 1.0.1 release Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> Co-authored-by: Genesys Developer Evangelists <developerevangelists@genesys.com> * Release/v2.0.0 (#46) * PCM-1667 (#22) * PCM-1667 added in changes for retryConnection function * PCM-1667 added changelog and bumped version * PCM-1667 updated Jenkinsfile * PCM-1667 revert Jenkinsfile for now * PCM-1667 updated changelog with tags * PCM-1667 updated changelog Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira updated jenkinsfile (#23) * no-jira updated jenkinsfile * no-jira updating jsx flag in tsconfig * no-jira update jsx flag in tsconfig * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira revert Jenksfile for test * no-jira updating jenkinsfile * no-jira updated jenkinsfile * no-jira updated jenkinsfile * no-jira reverted pipeline library used * no-jira updated jenkinsfile * no-jira updated .env file and Jenkinsfile * no-jira updated jenkinsfile and updated typescript version * no-jira updated unit test for utils.test.ts * no-jira reverted env file and put react-jsx as jsx value * no-jira changed testResults value * no-jira changed manifest back Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#25) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Pcm 1668 integration fixes (#30) * PCM-1668 working on fixing headset logic for reject call * PCM-1668 updated unit tests to now accommodate for reject call * PCM-1668 made changes to disconnect function to hopefully ensure connection statuses do not get crossed * PCM-1668 added await to connect * PCM-1668 added await to connect * PCM-1668 addressed PR concerns * PCM-1668 updated logic for connection status to do more of the heavy lifting within headset library * PCM-1668 fixed unit tests * PCM-1668 addressed PR comments * PCM-1668 version bump * PCM-1668 moved toLowercase to the library rather than consuming app; made change to test app to fix issue * no-jira added in snyk fixes * PCM-1668 version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * Updating to standard MIT license * Updating to standard MIT license * Integration fix (#36) * no-jira major version bump * 1.0.0 * no-jira fixed issue when no label is present; fixed unit tests; made SDK initialization more lazy * no-jira fixed issue when no label is present; fixed unit tests; made SDK initialization more lazy * no-jira version bump Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * [PCM-1903] add state management and fix typings * fix build artifact * various fixes for headset state and documentation * no-jira worked out issue with updating headset state through device changes (#44) Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira removed environments from deployConfig and autoSubmitCm from Jenkinsfile (#45) Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> * no-jira merge conflict resolution Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> Co-authored-by: Genesys Developer Evangelists <developerevangelists@genesys.com> Co-authored-by: Garrett Jensen <garrett.jensen@genesys.com> Co-authored-by: Garrett Jensen <jensen.gar@gmail.com> Co-authored-by: Maxwell Mooney <maxwell.mooney@genesys.com> Co-authored-by: Garrett Jensen <garrett.jensen@genesys.com> Co-authored-by: Genesys Developer Evangelists <developerevangelists@genesys.com> Co-authored-by: Garrett Jensen <jensen.gar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.