Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rethrow does not give any indication of the original error #2995

Closed
chharvey opened this issue Apr 1, 2018 · 1 comment
Closed

rethrow does not give any indication of the original error #2995

chharvey opened this issue Apr 1, 2018 · 1 comment

Comments

@chharvey
Copy link
Contributor

chharvey commented Apr 1, 2018

Continuing the discussion from pugjs/pug-runtime#35 (archived)

TypeError: Cannot set property message of  which has only a getter

The rethrow seems to be trying to set a property for which there is no setter. This is a bit frustrating because the trace of the new TypeError does not contain the original error, which makes debugging a lot harder.
chharvey added a commit to chharvey/pug that referenced this issue Apr 1, 2018
@chharvey
wrap setting err.message with a try/catch
761a104 
this attempts to bypass pugjs#2995 (a continuation of pugjs/pug-runtime#35)
chharvey added a commit to chharvey/pug that referenced this issue Apr 1, 2018
@chharvey
wrap setting err.message with a try/catch
9ff8cf2 
this attempts to bypass pugjs#2995 (a continuation of pugjs/pug-runtime#35)

note that this does not fix the bug. if setting `err.message` throws an error, the reason for that should be found and corrected.
@chharvey chharvey mentioned this issue Apr 1, 2018
Merged
@ghost
Copy link

ghost commented Apr 14, 2018

Once helped close the topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ForbesLindesay @chharvey