Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add r2.dev #1635

Closed
wants to merge 2 commits into from
Closed

Conversation

Frederik-Baetens
Copy link

@Frederik-Baetens Frederik-Baetens commented Oct 27, 2022

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowlegements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

Cloudflare provides CDN and DDOS protection, but we've recently launched R2, an object storage platform. This storage platform allows users to easily store arbitrary disorganized data for their applications.

I am a systems engineer at Cloudflare on the team that's working on R2. We already set up an alias to be contacted over, when setting up our workers.dev suffix (publicsuffixlist@cloudflare.com).

Organization Website: https://www.cloudflare.com/

Reason for PSL Inclusion

Cloudflare R2 customers can make their buckets publicly available. When doing so, the customer gets a unique r2.dev subdomain associated with their specific bucket. These domains should be treated as separate domains for cookie purposes. Since these domains will often be used to serve files, things like "Sorting in the download manager" for Firefox will also be a nice added benefit.

Example of such a public url: https://pub-ae08589711b94eb3a7bf08c8750ccf2b.r2.dev/dog.jpg

Number of users this request is being made to serve: This would concern R2 customers, and all of their users, which is a large amount. The exact amount of customers is something I cannot disclose. If that's a problem, I can see if I can get permission to publish an approximate number.

DNS Verification via dig

;; QUESTION SECTION:
;_psl.r2.dev.			IN	TXT

;; ANSWER SECTION:
_psl.r2.dev.		300	IN	TXT	"https://github.com/publicsuffix/list/pull/1635"

Results of Syntax Checker (make test)

All tests have passed.

@Frederik-Baetens Frederik-Baetens marked this pull request as draft October 28, 2022 00:41
@Frederik-Baetens Frederik-Baetens changed the title WIP: Add r2.dev Add r2.dev Oct 28, 2022
@Frederik-Baetens Frederik-Baetens marked this pull request as ready for review October 28, 2022 16:22
@dnsguru dnsguru changed the title Add r2.dev Add r2.dev Nov 7, 2022
@dnsguru dnsguru added the NOT IOS FB Submitter attests PR is not #1245 related label Nov 7, 2022
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Updater = Prior Submitter from org
  • tests pass
  • follows guidelines
  • no conflict with base
  • dns confirmation validated
    APPROVED

(thank you also for correcting prior sorting misconfig to align with guidelines)

@dnsguru dnsguru self-assigned this Nov 7, 2022
@dnsguru dnsguru added MAY DESERVE SECURITY REVIEW This is a PR that might benefit from a re-review 🩺 pending-validation Something needs to be validated and removed MAY DESERVE SECURITY REVIEW This is a PR that might benefit from a re-review 🩺 pending-validation Something needs to be validated labels Nov 7, 2022
@dnsguru
Copy link
Member

dnsguru commented Nov 7, 2022

This is clogged up with #1582 - please see notes in that PR

@dnsguru dnsguru added the waiting-followup Blocked for need of follow-up label Nov 7, 2022
@Frederik-Baetens
Copy link
Author

Closing since these changes were incorporated in #1582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NOT IOS FB Submitter attests PR is not #1245 related waiting-followup Blocked for need of follow-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants