Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using local and parallel builds for Travis #480

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

alaxalves
Copy link
Member

@alaxalves alaxalves commented Jan 30, 2020

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Thanks!

@alaxalves
Copy link
Member Author

image

Split the builds in 3, further we can improve it by splitting the tests, instead of running all tests, split them by 'model, controller, system...'

@SidharthBansal
Copy link
Member

LGtM 🎉
However it requires two approval for merging.
@emilyashley has just joined pl. Let's take a review from her.
Jeff is on vacation for Feb.

Copy link
Member

@emilyashley emilyashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@cesswairimu cesswairimu merged commit c8bda7a into publiclab:main Feb 19, 2020
@alaxalves alaxalves deleted the travis-improv branch February 26, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants