[Outreachy] Dashboard Redesign URL #8886
Conversation
|
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #8886 +/- ##
=======================================
Coverage ? 81.98%
=======================================
Files ? 100
Lines ? 5941
Branches ? 0
=======================================
Hits ? 4871
Misses ? 1070
Partials ? 0 |
Thanks 😄 , I was thinking of doing that with the design task in a follow-up PR... |
|
Code Climate has analyzed commit 42d89aa and detected 0 issues on this pull request. View more on Code Climate. |
|
@jywarren I'm curious, in the new next PR, should I create a new topics card partial or should I reuse the one within the tag views? |
oh, I'll recreate another one, I have just noticed slight differences... |
|
I wonder though if you may want to use conditionals to re-use the existing one to preserve consistency? But I trust your judgement! OK, this should be ready to merge then! |
|
Let's check it out on stable.publiclab.org once it publishes! Great work!!!! 🎉 🎉 🎉 🎉 |
* dashboard redesign * rename dashboard2 to dashboard_v2 * add subscription test and dashboard_v2 query * add limit to query
* dashboard redesign * rename dashboard2 to dashboard_v2 * add subscription test and dashboard_v2 query * add limit to query
* dashboard redesign * rename dashboard2 to dashboard_v2 * add subscription test and dashboard_v2 query * add limit to query
* dashboard redesign * rename dashboard2 to dashboard_v2 * add subscription test and dashboard_v2 query * add limit to query
Fixes #8831
I haven't fully completed the queries needed for the new dashboard page.
I would love some clarification.. Please have a look at the Dashboard screenshot on #8513 to get an idea on some of the questions I have raised within the comments.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment below