fix card page break and move to print layout #8415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #8415 +/- ##
==========================================
+ Coverage 81.87% 81.89% +0.02%
==========================================
Files 101 101
Lines 5902 5900 -2
==========================================
Hits 4832 4832
+ Misses 1070 1068 -2
|
|
Great, is it possible to see a before and after screenshot for this? |
|
can you please review @cesswairimu ? Thanks ❤️ Before (page break in card): -
After (no page break ):-
|
cesswairimu
approved these changes
Sep 21, 2020
|
Looks great! What does your view of the side cutoff look like now? Here's what we noticed with the righthand-side cut-off of the cards that Jeanette created: |
|
Hey @ebarry in the new print option there is no side cutoff since one card is displayed at a time as you can see from the above screenshots 😅 |
|
Awesome, thanks @Tlazypanda and everyone! |
|
ah wonderful! thank you 😄 |
shubhangikori
pushed a commit
to shubhangikori/plots2
that referenced
this pull request
Oct 12, 2020
alvesitalo
pushed a commit
to alvesitalo/plots2
that referenced
this pull request
Oct 14, 2020
piyushswain
pushed a commit
to piyushswain/plots2
that referenced
this pull request
Oct 22, 2020
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
ampwang
pushed a commit
to ampwang/plots2
that referenced
this pull request
Oct 26, 2021
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Fixed the card page break problem and moved to new print layout since bootstrap classes like
.cardwere not rendered as they should inlayout: falsesetting.rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!