Insight Section for Spam2 #8289

keshavsethi · 2020-08-11T21:22:45Z

[WIP]
Here I worked on the Insight section of Spam2 which contains stats related to the moderation and tags followed bt moderators and admins. Please refer to the following Screenshots:

@jywarren @ebarry @VladimirMikulic @pydevsg @emilyashley @ananyaarun @cesswairimu Please review!!
Thanks! ❤️

gitpod-io · 2020-08-11T21:22:48Z

keshavsethi · 2020-08-11T21:26:42Z

@jywarren @ebarry @VladimirMikulic @pydevsg @emilyashley @ananyaarun @cesswairimu If there is need of any other statistics then please suggest, I will work on that.
Thanks!!

codecov · 2020-08-11T21:26:57Z

Codecov Report

Merging #8289 into main will increase coverage by 0.58%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main    #8289      +/-   ##
==========================================
+ Coverage   81.28%   81.86%   +0.58%     
==========================================
  Files         101      101              
  Lines        5872     5900      +28     
==========================================
+ Hits         4773     4830      +57     
+ Misses       1099     1070      -29

Impacted Files	Coverage Δ
app/controllers/spam2_controller.rb	`71.84% <83.33%> (+10.30%)`	⬆️
app/controllers/batch_controller.rb	`90.19% <100.00%> (+22.23%)`	⬆️
app/models/node.rb	`91.37% <100.00%> (+0.18%)`	⬆️
app/models/tag.rb	`97.53% <100.00%> (+0.06%)`	⬆️

jywarren · 2020-08-11T21:55:18Z

Ooh, this is really good looking! Highlighting to staff.... thanks!

Also perhaps @cesswairimu and @Tlazypanda may want to look this over and offer input on the performance of the queries? This can pull a lot of data, i know!

Tlazypanda

Hey @keshavsethi I have just added some general suggestions that we might be able to use to improve performance 😅

Tlazypanda · 2020-08-12T10:33:40Z

app/views/spam2/_insights.html.erb

+    <div class="card-body">
+    <h5 class="card-title  text-secondary font-weight-bold"> <i class="fa fa-circle text-primary"></i>  Unmoderated</h5>
+      <ul class="list-group list-group-flush text-secondary ">
+        <li class="list-group-item"><%= Node.where(status: 4).count%> Nodes</li>


This seems the right usage of count but since we are replacing it with .size throughout the app so maybe can do it here to achieve consistency 😅 just a suggestion

Thanks @Tlazypanda, I will do this!! 👍

Tlazypanda · 2020-08-12T10:37:17Z

app/views/spam2/_insights.html.erb

+  <div class="card border-0">
+   <div class="card-body">
+    <h5 class="card-title  text-secondary font-weight-bold"> <i class="fa fa-tags text-primary"></i> Tags followed by moderators and admins</h5>
+    <% if @popular_tags.present? %>


Maybe use .exists? instead of .present? reference https://semaphoreci.com/blog/2017/03/14/faster-rails-how-to-check-if-a-record-exists.html also sidenote: @cesswairimu @jywarren should we do a refactoring for this in the app too?

ebarry · 2020-08-12T13:42:21Z

Awesome screenshots @keshavsethi ! What is the link where i can see this? Somewhere on https://stable.publiclab.org/spam2 ?

keshavsethi · 2020-08-16T01:43:02Z

Awesome screenshots @keshavsethi! What is the link where I can see this? Somewhere on https://stable.publiclab.org/spam2 ?

@ebarry This will be available on stable once it is merged, you can try this out in gitpod!!
Thanks

cesswairimu · 2020-08-16T16:58:40Z

These look great 🎉 great job @keshavsethi 🚀
I believe we have other graph_making and frequency methods. I will take a look see if there is a way we can refactor these two to reuse for both cases

jywarren

I think just a functional test at a minimum would make this ready to merge -- and if you can add a couple system tests for any basic interactive features you want to describe and protect, even better! Thanks @keshavsethi !!! This is very exciting.

jywarren · 2020-08-25T17:00:32Z

Hi @keshavsethi - happy to review but can you take a look at the Travis test failures first? I'll resolve the CodeClimate one. Thank you!!!

gitpod-io · 2020-08-25T17:01:14Z

jywarren · 2020-08-25T17:01:16Z

restarting tests just in case

jywarren · 2020-08-25T17:01:52Z

Strange, I "approved" codeClimate but it didn't show up here. This may need a rebase to pass everything? Thanks!!!

keshavsethi · 2020-08-25T17:35:38Z

Strange, I "approved" codeClimate but it didn't show up here. This may need a rebase to pass everything? Thanks!!!

@jywarren I have made some minor bug fixes. It should work now.
Thanks!! ❤️

jywarren · 2020-08-25T17:57:58Z

test/system/spam2_test.rb

@@ -159,4 +160,11 @@ def setup
    end
    assert_selector('#select-count', text: '2')
  end
+
+  test "unflag post in spam2/comments" do


This is great. Thank you!!!!

jywarren · 2020-08-25T17:58:39Z

Merging this!!! Thank you, @keshavsethi !!! Great work! Test it out please in stable server? Thank you!!!!

* insights for spam2 * ui changes and refactoring * refactoring * tests for spam2 * ui update and bug fixes * minor bug fixes

insights for spam2

f9abde8

keshavsethi requested review from cesswairimu, jywarren, VladimirMikulic and pydevsg August 11, 2020 21:24

jywarren requested a review from Tlazypanda August 11, 2020 21:55

Tlazypanda reviewed Aug 12, 2020

View reviewed changes

ui changes and refactoring

6d620b3

refactoring

a5ee023

keshavsethi requested a review from Tlazypanda August 16, 2020 01:51

jywarren requested changes Aug 18, 2020

View reviewed changes

keshavsethi mentioned this pull request Aug 18, 2020

Weekly Community Check-In #72 - Outreachy Wrap up publiclab/community-toolbox#386

Closed

tests for spam2

e2eda9e

keshavsethi requested a review from jywarren August 24, 2020 01:05

keshavsethi and others added 2 commits August 25, 2020 20:54

ui update and bug fixes

8138fb3

Merge branch 'main' into insights

b2e67fd

jywarren closed this Aug 25, 2020

jywarren reopened this Aug 25, 2020

minor bug fixes

d91665d

jywarren approved these changes Aug 25, 2020

View reviewed changes

jywarren merged commit baa7e7c into publiclab:main Aug 25, 2020

This was referenced Aug 25, 2020

Weekly Community Check-In #73 - GSoC Wrap up publiclab/spectral-workbench#541

Closed

GSoC'20: "Spam Management Dashboard" Project Planning #7885

Closed

nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020

Insight Section for Spam2 (publiclab#8289)

e68ae3c

* insights for spam2 * ui changes and refactoring * refactoring * tests for spam2 * ui update and bug fixes * minor bug fixes

shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020

Insight Section for Spam2 (publiclab#8289)

c47e5a0

* insights for spam2 * ui changes and refactoring * refactoring * tests for spam2 * ui update and bug fixes * minor bug fixes

alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020

Insight Section for Spam2 (publiclab#8289)

457767d

* insights for spam2 * ui changes and refactoring * refactoring * tests for spam2 * ui update and bug fixes * minor bug fixes

piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020

Insight Section for Spam2 (publiclab#8289)

66b253d

* insights for spam2 * ui changes and refactoring * refactoring * tests for spam2 * ui update and bug fixes * minor bug fixes

manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021

Insight Section for Spam2 (publiclab#8289)

07d9aed

* insights for spam2 * ui changes and refactoring * refactoring * tests for spam2 * ui update and bug fixes * minor bug fixes

lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021

Insight Section for Spam2 (publiclab#8289)

550094b

* insights for spam2 * ui changes and refactoring * refactoring * tests for spam2 * ui update and bug fixes * minor bug fixes

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021

Insight Section for Spam2 (publiclab#8289)

01d4390

* insights for spam2 * ui changes and refactoring * refactoring * tests for spam2 * ui update and bug fixes * minor bug fixes

ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021

Insight Section for Spam2 (publiclab#8289)

9b0d411

* insights for spam2 * ui changes and refactoring * refactoring * tests for spam2 * ui update and bug fixes * minor bug fixes

billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021

Insight Section for Spam2 (publiclab#8289)

e17a176

* insights for spam2 * ui changes and refactoring * refactoring * tests for spam2 * ui update and bug fixes * minor bug fixes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Insight Section for Spam2 #8289

Insight Section for Spam2 #8289

keshavsethi commented Aug 11, 2020 •

edited

Loading

gitpod-io bot commented Aug 11, 2020 •

edited

Loading

keshavsethi commented Aug 11, 2020

codecov bot commented Aug 11, 2020 •

edited

Loading

jywarren commented Aug 11, 2020

Tlazypanda left a comment

Tlazypanda Aug 12, 2020

keshavsethi Aug 16, 2020

Tlazypanda Aug 12, 2020

ebarry commented Aug 12, 2020

keshavsethi commented Aug 16, 2020

cesswairimu commented Aug 16, 2020

jywarren left a comment

jywarren commented Aug 25, 2020

gitpod-io bot commented Aug 25, 2020

jywarren commented Aug 25, 2020

jywarren commented Aug 25, 2020

keshavsethi commented Aug 25, 2020

jywarren Aug 25, 2020

jywarren commented Aug 25, 2020

Insight Section for Spam2 #8289

Insight Section for Spam2 #8289

Conversation

keshavsethi commented Aug 11, 2020 • edited Loading

gitpod-io bot commented Aug 11, 2020 • edited Loading

keshavsethi commented Aug 11, 2020

codecov bot commented Aug 11, 2020 • edited Loading

Codecov Report

jywarren commented Aug 11, 2020

Tlazypanda left a comment

Choose a reason for hiding this comment

Tlazypanda Aug 12, 2020

Choose a reason for hiding this comment

keshavsethi Aug 16, 2020

Choose a reason for hiding this comment

Tlazypanda Aug 12, 2020

Choose a reason for hiding this comment

ebarry commented Aug 12, 2020

keshavsethi commented Aug 16, 2020

cesswairimu commented Aug 16, 2020

jywarren left a comment

Choose a reason for hiding this comment

jywarren commented Aug 25, 2020

gitpod-io bot commented Aug 25, 2020

jywarren commented Aug 25, 2020

jywarren commented Aug 25, 2020

keshavsethi commented Aug 25, 2020

jywarren Aug 25, 2020

Choose a reason for hiding this comment

jywarren commented Aug 25, 2020

keshavsethi commented Aug 11, 2020 •

edited

Loading

gitpod-io bot commented Aug 11, 2020 •

edited

Loading

codecov bot commented Aug 11, 2020 •

edited

Loading