Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Driver dependencies and removal from travis #5750

Closed

Conversation

alaxalves
Copy link
Member

@alaxalves alaxalves commented May 21, 2019

Installing required dependencies for chrome driver and installing it in our docker image.

Fixes #5725 and #5683 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented May 21, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@plotsbot
Copy link
Collaborator

plotsbot commented May 21, 2019

1 Error
🚫 There was an error with Danger bot’s Junit parsing: undefined method `value’ for nil:NilClass
3 Messages
📖 @alaxalves Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.
📖 #<NoMethodError: undefined method `value’ for nil:NilClass>

Generated by 🚫 Danger

@alaxalves alaxalves force-pushed the issue5725-chrome-driver branch from 4278d87 to 6249a0f Compare May 21, 2019 02:17
@alaxalves alaxalves changed the title Chrome Driver dependencies and travis removal Chrome Driver dependencies and removal from travis May 21, 2019
@alaxalves alaxalves force-pushed the issue5725-chrome-driver branch from 6249a0f to f55a2e8 Compare May 21, 2019 02:41
@alaxalves alaxalves closed this May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include chrome-driver in our docker image
2 participants