Basic Setup of Action Cable #5744

namangupta01 · 2019-05-19T15:13:46Z

namangupta01 · 2019-05-19T15:16:26Z

@jywarren Here's the setup of the Action Cable. Have a look at it.

namangupta01 · 2019-05-19T15:23:19Z

After deploying this we can test this out.
Open public lab website in two different browser or computers and in one of the computer type App.room.speak('any_message') in the console and this message will appear in all the browser console of all the computers. This way we can check this out.

namangupta01 · 2019-05-19T15:24:53Z

After merging of this we can work further on this.

plotsbot · 2019-05-19T15:32:17Z

	2 Warnings
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!
⚠️	There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml

	2 Messages
📖	@namangupta01 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	#

Screenshots 📸 (click to expand)

Learn about automated screenshots

Generated by 🚫 Danger

namangupta01 · 2019-05-21T17:25:04Z

@jywarren @gautamig54 @gauravano Please review! Thanks

jywarren · 2019-05-24T21:56:45Z

I think rebasing this could pass tests, since we resolved some big test issues!

namangupta01 · 2019-05-25T16:54:16Z

Rebased let's hope it passes!

namangupta01 · 2019-05-25T17:04:51Z

@jywarren Tests has passed! I think we can ignore the codeclimate?

namangupta01 · 2019-05-31T17:46:13Z

@jywarren, @gautamig54 Have a look.

namangupta01 · 2019-06-05T20:29:52Z

Can anyone review ? Its pending from a long time.
Thanks

namangupta01 · 2019-06-05T20:30:34Z

@publiclab/reviewers

jywarren

Hi! I had a few questions, suggestions, etc! Also, once we resolve them, would you like to test this out on unstable to see how it does in a production environment?

Thanks @namangupta01 this is exciting!!!!

jywarren · 2019-06-05T22:24:26Z

app/assets/javascripts/channels/room.coffee

@@ -0,0 +1,13 @@
+App.room = App.cable.subscriptions.create "RoomChannel",


Hi @namangupta01 this is great, and I have nothing against CoffeeScript but do you think we should try to standardize so there's not a mix of coffeescript/javascript in the project? I'm open to suggestions but just thinking about newcomers and how much they have to learn to be able to work on this file... what do you think?

Sure! I will change it to javascript. 👍

jywarren · 2019-06-05T22:24:41Z

app/assets/javascripts/channels/room.coffee

+    # Called when the subscription has been terminated by the server
+
+  received: (data) ->
+      console.log("Response: " + data["message"]);


Will this affect all users, or is it turned "on" for just some?

As I said in the other comment. Room channel will be connected to all the sessions.

jywarren · 2019-06-05T22:25:46Z

app/channels/room_channel.rb

@@ -0,0 +1,13 @@
+class RoomChannel < ApplicationCable::Channel


What will correspond to a "room"? Are we aiming for notifications of comments to start with? Is each node a "room" and comments are messages in the room? Maybe we should make a "NodeChannel" instead, what do you think?

There will be multiple channels for multiple features, but I was thinking of making a room_channel which will be connected to all the users irrespective, in the case we want to use it in the future to send some notifications to all the users even they are logged in or not.
And I am going to make a differnt channel for a different feature, for example, node_channel, like_channel etc.
What do you say?

What are your thoughts about this @jywarren ?

Ah, my apologies for missing this!!! Yes, this sounds good; can you add this as a comment at the top of this file, just so there's some context?

namangupta01 · 2019-06-12T18:24:34Z

Hi @jywarren, if you can just take out one minute and have a look at it and pass it. I will complete it super soon. Just waiting for your suggestion on my comment. Thanks

namangupta01 · 2019-06-17T20:17:21Z

Hi! Please read my comments and let me know what do you think? I am hoping to merge this as soon as possible.

jywarren · 2019-06-19T13:50:07Z

Thanks Naman. Again, apologies for the slow response.

…ioncable_basic_setup

namangupta01 · 2019-06-20T19:42:04Z

@jywarren, I have done the suggested changes. And while testing on unstable I am getting error Error during WebSocket handshake: Unexpected response code: 404. I guess this is a NGINX error. Can you setup the NGINX with the configuration on the link https://stackoverflow.com/a/51048929. Thanks a lot.

namangupta01 · 2019-06-21T19:26:28Z

@jywarren How to see the configuration in https://jenkins.laboratoriopublico.org. Sorry, I checked but I didn't find any configuration.

icarito · 2019-06-21T20:56:01Z

Hi I just adjusted our unstable nginx config in accordance to the stackoverflow answer you posted! Please let me know if this works or we can tweak it!

server {                                                                                        
    listen 80;                                                                                  
    return 301 https://$server_name$request_uri;                                                
    server_name unstable.publiclab.org;                                                         
}                                                                                               
                                                                                                
server {                                                                                        
                                                                                                
#    listen 80;                                                                                 
    listen 443 ssl;                                                                             
                                                                                                
    server_name unstable.publiclab.org;                                                         
    error_page 502 https://jenkins.laboratoriopublico.org/job/Plots-Unstable/lastBuild/console; 
                                                                                                
    ssl_certificate      /etc/letsencrypt/live/unstable.publiclab.org/fullchain.pem;            
##    ssl_dhparam /etc/ssl/private/dhparams.pem;                                                
    ssl_certificate_key  /etc/letsencrypt/live/unstable.publiclab.org/privkey.pem;              
                                                                                                
    ssl on;                                                                                     
    ssl_session_cache  builtin:1000  shared:SSL:10m;                                            
    ssl_protocols  TLSv1 TLSv1.1 TLSv1.2;                                                       
    ssl_ciphers HIGH:!aNULL:!eNULL:!EXPORT:!CAMELLIA:!DES:!MD5:!PSK:!RC4;                       
    ssl_prefer_server_ciphers on;                                                               
                                                                                                
    location /api {                                                                             
        root /srv/plots_unstable/plots2/public/;                                                
        proxy_redirect off;                                                                     
        proxy_buffering off;                                                                    
        try_files $uri @plots_api;                                                              
    }                                                                                           
                                                                                                
    location @plots_api {                                                                       
      add_header              Access-Control-Allow-Origin *;                                    
      proxy_set_header        Host $host;                                                       
      proxy_set_header        X-Real-IP $remote_addr;                                           
      proxy_set_header        X-Forwarded-For $proxy_add_x_forwarded_for;                       
      proxy_set_header        X-Forwarded-Proto $scheme;                                        
                                                                                                
      proxy_pass          http://localhost:5001;                                                
                                                                                                
      proxy_redirect off;                                                                       
      proxy_buffering off;                                                                      
    }                                                                                           
    location / {                                                                                
        root /srv/plots_unstable/plots2/public/;                                                
        proxy_redirect off;                                                                     
        proxy_buffering off;                                                                    
        try_files $uri @plots;                                                                  
    }                                                                                           
                                                                                                
    location /cable {                                                                           
        proxy_pass          http://localhost:5001;                                              
        proxy_http_version 1.1;                                                                 
        proxy_set_header Upgrade websocket;                                                     
        proxy_set_header Connection Upgrade;                                                    
    }                                                                                           
                                                                                                
    location @plots {                                                                           
      proxy_set_header        Host $host;                                                       
      proxy_set_header        X-Real-IP $remote_addr;                                           
      proxy_set_header        X-Forwarded-For $proxy_add_x_forwarded_for;                       
      proxy_set_header        X-Forwarded-Proto $scheme;                                        
                                                                                                
      proxy_pass          http://localhost:5001;                                                
                                                                                                
      proxy_redirect off;                                                                       
      proxy_buffering off;                                                                      
    }                                                                                           
  }

…etup

namangupta01 · 2019-06-21T21:40:57Z

Hi @icarito, thanks for changing the conf. I also tried on my local with this configuration. This is working. But this is not working in unstable. Have you restarted the nginx?

namangupta01 · 2019-06-21T21:45:37Z

It's working after restarting nginx.

icarito · 2019-06-22T00:12:45Z

I "reloaded config" but didn't restart. I'll restart now in case it helps.

namangupta01 · 2019-06-22T11:57:43Z

I made some changes to config/production.rb. And finally, it worked and live on unstable.
@jywarren You can check this out on unstable by typing App.room.speak("hey") in the console and it will appear on all the sessions connected to unstable. You can test this out by opening the browser in a different tab, window or even computer.

And I guess this is now good to merge.
Thanks.

jywarren · 2019-06-22T16:21:04Z

Whoa! But shouldn't we limit to admins for now, as this is an easy way to spam?

…

On Sat, Jun 22, 2019, 7:58 AM Naman Gupta ***@***.***> wrote: I made some changes to config/production.rb. And finally, it worked and live on unstable. @jywarren <https://github.com/jywarren> You can check this out on unstable by typing App.room.speak("hey") in the console and it will appear on all the sessions connected to unstable. You can test this out by opening the browser in a different tab, window or even computer. And I guess this is now good to merge. Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5744?email_source=notifications&email_token=AAAF6J74SHSDFJWDTA3EZFTP3YHTRA5CNFSM4HN4WH32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYKH5VI#issuecomment-504659669>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J52DJRERTJY62OZLXLP3YHTRANCNFSM4HN4WH3Q> .

namangupta01 · 2019-06-22T16:41:38Z

Yeah! This is what I was hoping to do in the next part.

jywarren · 2019-06-22T21:23:55Z

I think maybe we'd better just add a quick check before merging even though it has no interface yet. You never know!

…

On Sat, Jun 22, 2019, 12:42 PM Naman Gupta ***@***.***> wrote: Yeah! This is what I was hoping to do in the next part. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5744?email_source=notifications&email_token=AAAF6J6B2TSIDI5PNTOROFLP3ZI4FA5CNFSM4HN4WH32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYKNBKI#issuecomment-504680617>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6JYASOLHU7IXKCBS2LTP3ZI4FANCNFSM4HN4WH3Q> .

namangupta01 · 2019-06-25T11:17:50Z

Sure! I am doing that. I have to add and destroy cookies while logging in and logout.

namangupta01 · 2019-06-25T15:10:35Z

@jywarren Please have a look. I have added cookie while loading the page so that the websocket connection is able to find the user and can use role of the user.

namangupta01 · 2019-06-25T15:32:03Z

Good to merge? What do you say?

grvsachdeva

Looks good to me!!

jywarren · 2019-06-25T21:41:17Z

app/controllers/application_controller.rb

+
+    cookies.signed["user_token"] = nil
+    if @current_user
+      cookies.signed["user_token"] = @current_user.persistence_token


Cool, so does this update the cookie on any usage of current_user, or when exactly? Thanks!

Once this is answered, I think we are good to merge, yes!!!

Hi, I am using current_user cookie to let the WebSocket while connecting to know that from which user the WebSocket is connecting so that we can do role-based functionality.

Because session is not available in ActionCable channels so while loading page we check for current_user and when we are checking for current_user we set the cookie so that the websocket can let the action cable know which user it is.

@jywarren Does this helps?

Yep, just want to know, when logging out, will the cookie then be flushed?

Can you add any test for this, perhaps a system test? We can do it in follow-up, but I'd like to protect this with some tests.

I thought that current_user function will be called when we log out and the browser redirect it to any page. But it good to specifically set the cookie while logging out.
Doing it.
Thanks!

And regarding System Test, yes we can do this in the follow up pr.

I guess it is not needed to set the cookie to nil because while logging out we change the persistence token of the user.

plots2/app/controllers/user_sessions_controller.rb

Line 213 in 7b55c88

current_user&.reset_persistence_token!

What do you say? I guess it is not needed. Let me know what do you think?

jywarren · 2019-06-27T18:36:52Z

OK, then, that sounds good! Shall we merge now? Thanks Naman, for being careful here!

…

On Thu, Jun 27, 2019 at 2:33 PM Naman Gupta ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In app/controllers/application_controller.rb <#5744 (comment)>: > @@ -91,6 +91,12 @@ def current_user # Ensures no code will use old @current_user info. Treat the user # as anonymous (until the login process sets @current_user again): @current_user = nil + + end + + cookies.signed["user_token"] = nil + if @current_user + cookies.signed["user_token"] = @current_user.persistence_token I guess it is not needed to set the cookie to nil while logging out because we change the persistence token of the user while logging out. https://github.com/publiclab/plots2/blob/7b55c883e79d33569482f9a32389914e509705d0/app/controllers/user_sessions_controller.rb#L213 What do you say? I guess it is not needed. Let me know what do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5744?email_source=notifications&email_token=AAAF6JZKB4WUMX5RGUF3OVDP4UBTXA5CNFSM4HN4WH32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB44TBGI#discussion_r298313294>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J2KYCMBCCIQXLFSHSLP4UBTXANCNFSM4HN4WH3Q> .

namangupta01 · 2019-06-27T19:04:08Z

Yeah!!!! On Fri, Jun 28, 2019 at 12:06 AM Jeffrey Warren <notifications@github.com> wrote:

…

OK, then, that sounds good! Shall we merge now? Thanks Naman, for being careful here! On Thu, Jun 27, 2019 at 2:33 PM Naman Gupta ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In app/controllers/application_controller.rb > <#5744 (comment)>: > > > @@ -91,6 +91,12 @@ def current_user > # Ensures no code will use old @current_user info. Treat the user > # as anonymous (until the login process sets @current_user again): > @current_user = nil > + > + end > + > + cookies.signed["user_token"] = nil > + if @current_user > + cookies.signed["user_token"] = @current_user.persistence_token > > I guess it is not needed to set the cookie to nil while logging out > because we change the persistence token of the user while logging out. > > https://github.com/publiclab/plots2/blob/7b55c883e79d33569482f9a32389914e509705d0/app/controllers/user_sessions_controller.rb#L213 > What do you say? I guess it is not needed. Let me know what do you think? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #5744?email_source=notifications&email_token=AAAF6JZKB4WUMX5RGUF3OVDP4UBTXA5CNFSM4HN4WH32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB44TBGI#discussion_r298313294 >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AAAF6J2KYCMBCCIQXLFSHSLP4UBTXANCNFSM4HN4WH3Q > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5744?email_source=notifications&email_token=AE6AEYJXOWTX5J2E4SYRJLTP4UCERA5CNFSM4HN4WH32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYYACFQ#issuecomment-506462486>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE6AEYN2YWLEE6RMLEATBZDP4UCERANCNFSM4HN4WH3Q> .

jywarren · 2019-06-27T19:07:32Z

Ok great! Please test out on stable too!

* Added room channel * Basic Setup Of Action Cable * Basic Implementation of Testing Channel Completed * Minor Change * Minor Change * Minor Change * Added room channel code in js and removed code in coffeescript * Added ActionCable Config Url and Action Cable Allowed Request Origin * Added ActionCable Config Url and Action Cable Allowed Request Origin * Added ActionCable Config Url and Action Cable Allowed Request Origin * Added Cookie for identifying user in websocket connection * Minor Changes

namangupta01 added review-me summer-of-code labels May 19, 2019

namangupta01 added the gsoc label May 19, 2019

namangupta01 added 6 commits May 25, 2019 22:23

Added room channel

4bfcb61

Basic Setup Of Action Cable

0d8864f

Basic Implementation of Testing Channel Completed

c65faf8

Minor Change

99d85b9

Minor Change

218254a

Minor Change

d382520

namangupta01 force-pushed the actioncable_basic_setup branch from efd2fbf to d382520 Compare May 25, 2019 16:53

jywarren requested changes Jun 5, 2019

View reviewed changes

namangupta01 mentioned this pull request Jun 13, 2019

Weekly community check-in #25 (Favourite IDE) publiclab/simple-data-grapher#41

Closed

namangupta01 added 2 commits June 20, 2019 23:49

Merge branch 'master' of https://github.com/publiclab/plots2 into act…

e4334aa

…ioncable_basic_setup

Added room channel code in js and removed code in coffeescript

a189147

Merge remote-tracking branch 'origin/master' into actioncable_basic_s…

af7c092

…etup

namangupta01 added 3 commits June 22, 2019 12:42

Added ActionCable Config Url and Action Cable Allowed Request Origin

6bf803c

Added ActionCable Config Url and Action Cable Allowed Request Origin

7c9232a

Added ActionCable Config Url and Action Cable Allowed Request Origin

88cea8a

Added Cookie for identifying user in websocket connection

ccde4f3

namangupta01 force-pushed the actioncable_basic_setup branch from 55691b2 to ccde4f3 Compare June 25, 2019 15:03

Minor Changes

8bff52a

grvsachdeva approved these changes Jun 25, 2019

View reviewed changes

jywarren reviewed Jun 25, 2019

View reviewed changes

jywarren merged commit 61684ae into master Jun 27, 2019

namangupta01 mentioned this pull request Aug 15, 2019

Sockets/notifications error #6138

Open

ViditChitkara mentioned this pull request Sep 19, 2019

Issue with image position saving on stable server publiclab/mapknitter#1041

Closed

		@@ -0,0 +1,13 @@
		App.room = App.cable.subscriptions.create "RoomChannel",

		@@ -0,0 +1,13 @@
		class RoomChannel < ApplicationCable::Channel

Basic Setup of Action Cable #5744

Basic Setup of Action Cable #5744

Conversation

namangupta01 commented May 19, 2019

namangupta01 commented May 19, 2019

namangupta01 commented May 19, 2019 • edited Loading

namangupta01 commented May 19, 2019

plotsbot commented May 19, 2019 • edited Loading

namangupta01 commented May 21, 2019

jywarren commented May 24, 2019

namangupta01 commented May 25, 2019

namangupta01 commented May 25, 2019

namangupta01 commented May 31, 2019

namangupta01 commented Jun 5, 2019

namangupta01 commented Jun 5, 2019

jywarren left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

namangupta01 commented Jun 12, 2019

namangupta01 commented Jun 17, 2019

jywarren commented Jun 19, 2019

namangupta01 commented Jun 20, 2019

namangupta01 commented Jun 21, 2019

icarito commented Jun 21, 2019

namangupta01 commented Jun 21, 2019

namangupta01 commented Jun 21, 2019

icarito commented Jun 22, 2019

namangupta01 commented Jun 22, 2019

jywarren commented Jun 22, 2019 via email

namangupta01 commented Jun 22, 2019

jywarren commented Jun 22, 2019 via email

namangupta01 commented Jun 25, 2019

namangupta01 commented Jun 25, 2019

namangupta01 commented Jun 25, 2019

grvsachdeva left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

namangupta01 Jun 27, 2019 • edited Loading

Choose a reason for hiding this comment

jywarren commented Jun 27, 2019 via email

namangupta01 commented Jun 27, 2019 via email

jywarren commented Jun 27, 2019

namangupta01 commented May 19, 2019 •

edited

Loading

plotsbot commented May 19, 2019 •

edited

Loading

namangupta01 Jun 27, 2019 •

edited

Loading