Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Follow button aligned in the middle #5106

Merged
merged 4 commits into from
Mar 17, 2019
Merged

Update Follow button aligned in the middle #5106

merged 4 commits into from
Mar 17, 2019

Conversation

luanafaustini
Copy link
Contributor

@luanafaustini luanafaustini commented Mar 16, 2019 •
edited by grvsachdeva
Loading

Fixes #5051 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • PR is descriptively titled 📑
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@luanafaustini
Update _tags.html.erb line 5
c7ff55b 
This update was to change the buttom that was aligning on the left to align in the middle.
@luanafaustini
Merge pull request #1 from luanafaustini/luanafaustini-patch-1 issue p…
08ec69c 
…ubliclab#5051

Update _tags.html.erb line 5 to centralize the button
@welcome
Copy link

welcome bot commented Mar 16, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
Also, can you tell us your Twitter handle so we can thank you properly?

@IshaGupta18
Copy link
Collaborator

I think this is ready to be merged @gauravano !

@grvsachdeva
Copy link
Member

@luanafaustini there is a merge conflict. Please resolve that. Thanks!

@grvsachdeva
Copy link
Member

Suggestion: Try to open a PR using a separate feature-branch from next time so as that helps in keeping your master branch clean. Thanks!

@IshaGupta18
Copy link
Collaborator

Oh yes, I must have overlooked it, my apologies @gauravano

@IshaGupta18
Copy link
Collaborator

Yes, also, to keep your local fork up to date with the remote repo, keep syncing it from time to time. The egghead series given in the welcome post is a big help!

@plotsbot
Copy link
Collaborator

plotsbot commented Mar 17, 2019 •
edited
Loading

1 Warning
⚠️ It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!
3 Messages
📖 @luanafaustini Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 Your pull request is on the master branch. Please make a separate feature branch) with a descriptive name like new-blog-design while making PRs in the future.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

grvsachdeva
grvsachdeva approved these changes Mar 17, 2019
View reviewed changes
Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @luanafaustini!

@grvsachdeva grvsachdeva merged commit 6507b55 into publiclab:master Mar 17, 2019
@welcome
Copy link

welcome bot commented Mar 17, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

@grvsachdeva
Copy link
Member

Merged 💯 🎉

@luanafaustini
Copy link
Contributor Author

luanafaustini commented Mar 17, 2019 •
edited
Loading

Thank you @gauravano
it took some time, but it finally worked :) I will do better next time.

@IshaGupta18
Copy link
Collaborator

IshaGupta18 commented Mar 17, 2019 via email

icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
@luanafaustini @icarito
Update Follow button aligned in the middle (publiclab#5106)
cd44adf 
* Update _tags.html.erb line 5

This update was to change the buttom that was aligning on the left to align in the middle.

* adding removed code
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@luanafaustini @grvsachdeva
Update Follow button aligned in the middle (publiclab#5106)
aa6d56c 
* Update _tags.html.erb line 5

This update was to change the buttom that was aligning on the left to align in the middle.

* adding removed code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grvsachdeva grvsachdeva grvsachdeva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luanafaustini @IshaGupta18 @grvsachdeva @plotsbot