-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newline character to message displayed on the dashboard #4981
Add newline character to message displayed on the dashboard #4981
Conversation
Generated by 🚫 Danger |
Hi, @gauravano, could you please review this, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madeofhuman , I think it would be better if the line "You've shared 0 research notes." is on the next line as shown in the screen shot i attached in the issue template. Although since this is a UI change it requires discussion.
Here take a look, this is what i meant.
We have to wait a bit to get a word from @jywarren as this is a UI change. @madeofhuman, you can start working on other issues in the meantime. Thanks! |
d54d2d5
to
fe161b0
Compare
I've updated it @ananyaarun. Thanks for the feedback. |
All right, @gauravano. I'll look for another issue. Thank you. |
Great! |
Hi! I appreciate this, but I think it pushes down the rest of the page a bit much. Also, i want to be aware that we are soon going to be doing a bigger redesign of the dashboard at #4922, so perhaps we could start preparing for that instead? Thank you!!! |
Sure, man @jywarren. No problem. Looking forward to working on the new designs. |
Thanks for raising PR @madeofhuman. Closing this for now. |
Fixes #4977
Before:

After:

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!