Link login modal questions

[okonek]

Fixes #4159 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[okonek]

@SidharthBansal Is it ok? When the user is not logged in and he clicks the spam button the login modal shows up and then redirects.

[SidharthBansal]

Awesome. Please claim the task on the dashboard so that we can reward you.

[okonek]

I claimed it: https://codein.withgoogle.com/dashboard/task-instances/4522206253023232/

[okonek]

Thank you!

[plotsbot]

	2 Messages
📖	@okonek Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[SidharthBansal]

@jywarren please review and merge this.

[jywarren]

I think it's starting to take up a lot of space here -- and we'd like to have the "flag" associated with the "spam" -- what if we had a single Flag button which opens up a Bootstrap popover, which shows "Flag" this to moderators (email) and "Spam" this if you are a moderator (and link to learn more about moderators). These could fit under just one tiny flag icon, and expand out when you click it.

However, you've successfully completed the original task even if this isn't merged yet -- so you should get approved for the task! Thanks!

[SidharthBansal]

I have already rewarded him the points

[SidharthBansal]

I think it's starting to take up a lot of space here -- and we'd like to have the "flag" associated with the "spam" -- what if we had a single Flag button which opens up a Bootstrap popover, which shows "Flag" this to moderators (email) and "Spam" this if you are a moderator (and link to learn more about moderators). These could fit under just one tiny flag icon, and expand out when you click it.

I think we should merge this now. And open up a different issue for the above comment. We can brainstorm on it. What do you say?

[jywarren]

It's OK - we can just leave it open with the task approved... and solve this in follow-up in the same PR. Sound OK?

[SidharthBansal]

Sounds great!!!

…

On Mon, Dec 10, 2018 at 10:50 PM Jeffrey Warren ***@***.***> wrote: It's OK - we can just leave it open with the task approved... and solve this in follow-up in the same PR. Sound OK? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4255 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQyA38FRdCx_lZH6eEwqVdC9kG5fFks5u3pfvgaJpZM4ZLoND> .

[jywarren]

OK - thanks for your patience - how about this as a solution:

where the top has a flag icon, the two middle ones have the ban (like circle with slash) icon, and the bottom is a link to /moderators

(mockup made in this doc)

[jywarren]

The ones that say "only mods and admins" could be a link instead that says "Log in to moderate" maybe... but really you'd still have to become a mod or admin to be able to so I don't know if it's necessary?

And since we have these flag icons in so many places, maybe we should think about making this a partial template or something standard (as with the login modal) we can insert anywhere?

[SidharthBansal]

Oh it is so nice.
It is compact design and also reduced redundancy and ambiguity.
I really loved it
We can first complete this issue. Once we complete this issue we can raise an issue to identify these flag icons at different places throughout the website. Then we can create ftos for linking flag buttons to partials and for deletion of the redundant buttons.

[grvsachdeva]

Hi @okonek would you like to implement the design suggested by @jywarren ? Thanks!

[SidharthBansal]

Due to recent changes by Kevin and design suggested by Jeff, we need to change this code a lot. So, I am closing this PR. @okonek please feel free to open up a PR for the design suggested by Jeff () and then a follow up PR for the linking of modals(#4255).

[SidharthBansal]

These changes are no longer needed due to new PRs merged.

[SidharthBansal]

Please feel free to open a new pr @okonek
Thanks for awesome work you are doing at PL