Moved all files from app/views/comment to app/view/comments #4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, what do I have to do for those tests to pass? I didn't even edit those files. Please help @publiclab/reviewers |
Generated by 🚫 Danger |
|
What should I do there? I didn't even edit theese files that have error in codeclimate. Help |
Closed
|
It's fine, you don't have to worry about codeclimate errors. |
|
Hey @okonek just a suggestion, like you can see in the PR body, in checklist we ask contributors to open PR on feature-branch, so that master branch remain clean. |
|
Thanks, so what do I have to do in there? |
|
You cant do anything for now, but for next PR you can do the work on a feature branch instead of master |
|
Great work here!!! Thanks so much!! |
ghost
removed
the
jonxuxu
pushed a commit
to jonxuxu/plots2
that referenced
this pull request
Dec 2, 2018
…b#4028) * Moved all files from app/views/comment to app/view/comments * Added a redirect from comment to comments in routes.rb * Changed response view in the delete and create method in the comment controller * Changed an assert in comment_controller_test to match the new paths
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
…b#4028) * Moved all files from app/views/comment to app/view/comments * Added a redirect from comment to comments in routes.rb * Changed response view in the delete and create method in the comment controller * Changed an assert in comment_controller_test to match the new paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3339 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!