Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dashboard from the dropdown menu updated _header.html.erb #3548

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

vsk4
Copy link
Member

@vsk4 vsk4 commented Oct 1, 2018

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes changes as reference to original issue Remove Dashboard from the dropdown menu #3327
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Oct 1, 2018

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@vsk4 vsk4 changed the title Update _header.html.erb Remove Dashboard from the dropdown menu Oct 1, 2018
@vsk4 vsk4 changed the title Remove Dashboard from the dropdown menu Remove Dashboard from the dropdown menu updated _header.html.erb Oct 1, 2018
@vsk4
Copy link
Member Author

vsk4 commented Oct 1, 2018

@jywarren please review

@plotsbot
Copy link
Collaborator

plotsbot commented Oct 1, 2018

2 Messages
📖 @vsk4 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 Your pull request is on the master branch. Please make a separate feature branch) with a descriptive name like new-blog-design while making PRs in the future.

Generated by 🚫 Danger

@jywarren jywarren merged commit 2898e63 into publiclab:master Oct 1, 2018
@welcome
Copy link

welcome bot commented Oct 1, 2018

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step! See: https://code.publiclab.org

@jywarren
Copy link
Member

jywarren commented Oct 1, 2018

👍 🎉 😄

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants