Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont follow tags #1455

Closed
wants to merge 3 commits into from
Closed

Dont follow tags #1455

wants to merge 3 commits into from

Conversation

StlMaris123
Copy link
Collaborator

@StlMaris123 StlMaris123 commented Jun 8, 2017

related to #1421

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

@PublicLabBot
Copy link

3 Messages
📖 @StlMaris123 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution!
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@ananyo2012
Copy link
Member

Hi @StlMaris123 Is there any issue regarding this? You could mention that in the PR description. As of now the title of the PR is unclear.

@StlMaris123 StlMaris123 changed the title Dont follow tags Dont follow tags fixes#1421 Jun 8, 2017
@jywarren jywarren changed the title Dont follow tags fixes#1421 Dont follow tags fixes #1421 Jun 9, 2017
@jywarren jywarren changed the title Dont follow tags fixes #1421 Dont follow tags Jun 9, 2017
@jywarren
Copy link
Member

jywarren commented Jun 9, 2017

Just changed this so it doesn't close the planning issue, but does get connected to it.

@jywarren
Copy link
Member

jywarren commented Jun 9, 2017

But please mark this as WIP as the method is currently empty! Great work getting these started, StellaMaris!

@StlMaris123
Copy link
Collaborator Author

I have combined this PR in email when tag is added since they are related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants