Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create update_issue_#11009 #11044

Closed
wants to merge 1 commit into from
Closed

Conversation

ayish1998
Copy link
Contributor

@ayish1998 ayish1998 commented Apr 12, 2022

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Apr 12, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Apr 12, 2022

@codeclimate
Copy link

codeclimate bot commented Apr 12, 2022

Code Climate has analyzed commit e6b9862 and detected 0 issues on this pull request.

View more on Code Climate.

@ayish1998
Copy link
Contributor Author

@TildaDares can u review on this please

@Somya-Singhal
Copy link
Contributor

Hello @ayish1998, you have to mention the issue number which is linked with this pull request in place of #0000. Thank you!
image

I am attaching a sample screenshot below, you can refer to it
image

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6089853127/artifacts/211051291

@ayish1998
Copy link
Contributor Author

hello @Somya-Singhal thank you

@TildaDares
Copy link
Member

Hi @ayish1998, can you add the issue link to the description above? The issue number is at the top of the page(next to the issue title) you were assigned and starts with #. Thanks!

@TildaDares TildaDares linked an issue Apr 13, 2022 that may be closed by this pull request
5 tasks
@TildaDares
Copy link
Member

Hi @ayish1998, you are not supposed to replace the entire content of the file. The lines in red should be removed and the ones in green should be added. Can you take a look at the issue again and read the description? Thanks!!

@ayish1998
Copy link
Contributor Author

@TildaDares that's exactly what I actually did. I removed the ones with red highlights and replaced them with the green.

@TildaDares
Copy link
Member

@ayish1998 Actually it looks like you copied everything.

@TildaDares
Copy link
Member

Hi @ayish1998, do you need help with this?

@ayish1998
Copy link
Contributor Author

@TildaDares I think so because I don't really know if the instruction I followed is not what is expected.

@TildaDares
Copy link
Member

@TildaDares
Copy link
Member

Hi @ayish1998, any updates on this?

@ayish1998
Copy link
Contributor Author

All checks have passed

11 successful checks

@ayish1998 ayish1998 closed this Apr 21, 2022
@ayish1998
Copy link
Contributor Author

@TildaDares sorry for the late response, I was having exams. Yes, I think I need help.

@TildaDares
Copy link
Member

Hi @ayish1998, just follow the steps I outlined here #11044 (comment).

@ayish1998
Copy link
Contributor Author

@TildaDares Please on the project timeline, do you have a specific comment on this?

@TildaDares
Copy link
Member

@ayish1998 You’re expected to break down the project tasks into smaller parts for each week.

@ayish1998
Copy link
Contributor Author

@TildaDares Please do that means I will choose my timing?

@TildaDares
Copy link
Member

Yes you choose your timing.

@ayish1998
Copy link
Contributor Author

Thank you @TildaDares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typos and indentation in _queue.html.erb
3 participants