Fixes #10823: Refined people's list

[KarishmaVanwari]

1. Removed unnecessary "Show x more" entry
2. Scrollable table

Fixes #10823

Screenshot:

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

[gitpod-io]

[github-actions]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5835108003/artifacts/195981669

[jywarren]

Hi, this is looking really good! Unfortunately (my fault) it broke a test but actually we need to adjust the test to the new behavior, so it's not your fault!

Lines 264 and 183 of test/unit/node_shared_test.rb are looking for too many lines; now that we've changed the # of rows, we should adjust the count to 4 in both cases:

plots2/test/unit/node_shared_test.rb

Line 183 in ba254cf

assert_equal 6, html.scan('people-grid').length

Does that make sense? If you can add this change to the same PR and push up another commit, it will resolve the error! Let us know if you need any help with that, we're happy to explain.

Thanks again for taking this on!

NodeSharedTest#test_about_ability_of_power_tags_to_exclude_tags_like_[people:organizer!foo1] (18.58s)
        Expected: 6
          Actual: 4
        test/unit/node_shared_test.rb:264:in `block in <class:NodeSharedTest>'

/home/runner/work/plots2/plots2/vendor/bundle/ruby/2.7.0/gems/actionview-5.2.7/lib/action_view/helpers/translation_helper.rb:[99](https://github.com/publiclab/plots2/runs/5727592239?check_suite_focus=true#step:5:99): warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/home/runner/work/plots2/plots2/vendor/bundle/ruby/2.7.0/gems/i18n-1.10.0/lib/i18n.rb:210: warning: The called method `translate' is defined here
=== FAIL NodeSharedTest#test_that_NodeShared_can_be_used_to_convert_short_codes_like_[people:organizer]_into_maps_which_display_notes,_but_only_those_tagged_with_"organizer" (19.02s)
        Expected: 6
          Actual: 4
        test/unit/node_shared_test.rb:183:in `block in <class:NodeSharedTest>'

=======|

[codeclimate]

Code Climate has analyzed commit 8e8d1a6 and detected 0 issues on this pull request.

View more on Code Climate.

[KarishmaVanwari]

Hey @jywarren, I've pushed a commit with the change in the count. Hope it works. Thanks :)

[codecov]

Codecov Report

Merging #10863 (2e10736) into main (ba254cf) will increase coverage by 0.12%.
The diff coverage is 94.11%.

❗ Current head 2e10736 differs from pull request most recent head 8e8d1a6. Consider uploading reports for the commit 8e8d1a6 to get more accurate results

@@            Coverage Diff             @@
##             main   #10863      +/-   ##
==========================================
+ Coverage   82.32%   82.45%   +0.12%     
==========================================
  Files          98       98              
  Lines        5993     5991       -2     
==========================================
+ Hits         4934     4940       +6     
+ Misses       1059     1051       -8     

Impacted Files	Coverage Δ
app/models/node.rb	91.27% <ø> (ø)
app/helpers/user_tags_helper.rb	33.33% <50.00%> (+4.76%)	⬆️
app/controllers/users_controller.rb	80.78% <100.00%> (ø)
app/models/image.rb	82.05% <100.00%> (ø)
app/models/user.rb	86.64% <100.00%> (+0.52%)	⬆️
app/api/srch/search.rb	70.70% <0.00%> (+3.82%)	⬆️
app/services/execute_search.rb	94.44% <0.00%> (+5.55%)	⬆️

[github-actions]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5873195912/artifacts/198263940

[cesswairimu]

This is looking good @KarishmaVanwari , great work, thanks

[jywarren]

Excellent work, thank you!!

[KarishmaVanwari]

Thank you so much @jywarren @cesswairimu !! :)