Display alert on "candidate" activity posts with prompt to "adapt" them, fixes #839 #1078
Conversation
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| <div class="col-md-9 note-show<% if @node.status == 4 || @node.status == 0 %> moderated<% end %>"> | |||
| <% if current_user && @node.tags.length == 0 %><div class="alert alert-warning"><%= raw t('notes.show.note_no_tags') %></div><% end %> | |||
| <% if @node.has_power_tag('status:candidate') %><div class="alert alert-info"><a href="https://publiclab.org/notes/warren/09-17-2016/what-makes-a-good-activity" >read about how to adapt its content</a></div> | |||
There was a problem hiding this comment.
Ah - actually we should have this whole line -- sorry i wasn't specific enough and thank you!
This was marked as a candidate activity -- read about how to adapt its content into a fully-fledged, step-by-step activity that can be easily replicated.
jywarren
changed the title
|
Also note how I added |
|
Okay I will add it. Thanks! |
|
Super! Thanks! |
|
But why was it failing tests? |
|
Oh, i'm not sure but manually checking it showed that it's OK -- you know, actually I think merging too fast can cause it to fail since it may no longer be able to access the code from the pull request. I guess i should always let them run through before merging. Tests will run on master automatically though so it's OK! Curious - do you think this could be an interesting next one to try? #397 |
|
It's multi-part, and a bit more complex, but I think you've gotten the idea of power tags well, and are ready for something like that -- and I'm happy to help! |
|
I can have a look at it. Thanks! |
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake test:allschema.rb.examplehas been updated if any database migrations were addedPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.
Thanks!