Followup to Solr integration -- installation steps

[jywarren]

Solr is now a requirement to run tests, which may increase barriers for newcomers. I'd like to take some steps to make this process easier:

• update README to show solr installation: apt-get install openjdk-7-jre openjdk-7-jdk icedtea-7-plugin
• remove duplicate rake db:setup and check if @icarito added those (or if we can remove them)
• build rake sunspot:solr:start into rake test task until we separate it out
• check cloud9 startup script to add java installation and solr startup lines: https://github.com/publiclab/plots2/blob/master/install_cloudnine.sh
• see if we can turn off Solr dependencies for most tests, and separate out Solr tests to be optionally run under a rake test:solr task
• complete advanced search fixes in (Link to) advanced search is wack! #800
• fix typeahead (RESTful typeahead display using standard bootstrap css #742)

[icarito]

I did not find the duplicate rake db:setup but it would be best to join both apt-get commands and drop the icedtea7-plugin which is not required

[jywarren]

ah, i already removed it and tested it, thanks -- maybe it resulted during
a rebase conflict. Oh, and somehow I didn't realize the icedtea7 plugin
wasn't required... must've mistakenly used that from a Stack Overflow
example. We should remove it from the Docker setup but also from the README
(i just updated that as well).

On Thu, Sep 22, 2016 at 3:37 PM, Sebastian Silva notifications@github.com
wrote:

I did not find the duplicate rake db:setup but it would be best to join
both apt-get commands and drop the icedtea7-plugin which is not required

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#832 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ5sanlNRuajQ9DQ7Lm63PJ2JQ-F0ks5qstj3gaJpZM4KC3zw
.

[jywarren]

In development mode, I'm getting:

Error:     {msg=SolrCore 'development' is not available due to init failure: Index locked for write for core 'development'. Solr now longer supports forceful unlocking via 'unlockOnStartup'. Please verify locks manually!,trace=org.apache.solr.common.SolrException: SolrCore 'development' is not available due to init failure: Index locked for write for core 'development'. Solr now longer supports forceful unlocking via 'unlockOnStartup'. Please verify locks manually!

I think this could be due to having started a second Solr instance for development, on top of the one I'm running for testing. This could be a common gotcha which we could build into the rake tasks...

[jywarren]

Yes -- that seems to have been the error -- and I had to shut both solr instances down and start up the right one before it worked.

[ananyo2012]

Ok seeing the discussion here the icedtea-7-plugin isn't required. But I am getting the same error as Jeff mentioned in the previous comment.

[ananyo2012]

Ah thanks Jeff! Sorry I didn't follow this before. I was having the same problem. Tests are running smoothly now. I think we should add this to the readme.

[ananyo2012]

@jywarren Should I remove the icedtea-7-plugin from the Dockerfile and Readme and update the readme with the test case as well?

[jywarren]

Yes please!

[ananyo2012]

Removed icedtea-7-plugin and updated the readme in #846

[jywarren]

Thanks!!!!

On Tue, Sep 27, 2016 at 10:08 AM, Ananya Maiti notifications@github.com
wrote:

Removed icedtea-7-plugin and updated the readme in #846
#846

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#832 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ1E93VzA2BbI8Lpjz748UR8JRl3Xks5quSN7gaJpZM4KC3zw
.

[ananyo2012]

@jywarren A lot of new contributors have come up in recently and they are facing problems in working up with the cloud9 installation. I can work on the cloud9 installation issues and building the rake tasks if you insist Jeff!

[ananyo2012]

@jywarren I was thinking if could somehow start and stop the solr server along with the rails server it would be great. Basically what we have to do is find a way to run a rake task while starting a stopping the rails server.

[ananyo2012]

@jywarren I am a bit stuck on this. Is there any way to find whether the solr server is already running? We have to put a condition to start the solr server in the test environment only if it is not already running. Otherwise rake is aborted due to the already running solr server. Similarly we need to stop the solr server in development only if it is running.

[jywarren]

Hmm, i'm not sure -- doing some searches for "detect solr running" -- but perhaps while you work on this, I could -- in parallel -- see if it's possible to skip Solr dependent tests and have a rake test:nosolr task for that.

[jywarren]

Unit tests may be omitted: http://stackoverflow.com/questions/2927405/how-to-skip-certain-tests-with-testunit#2940755

Looking for same with functional tests.

[jywarren]

This is saying that you could just ping the solr service via wget, for example...

This is saying that you can check /admin/ping using wget. I mean, this'd assume that the client has wget to use rake, so that doesn't seem ideal...

[jywarren]

Alternatively, we could actually move the Solr tests in searches_controller_test.rb into /test/solr/, and run them with a separate rake test:solr command -- based on this way of running a single test:

ruby -I test test/functional/whatevertest.rb

[jywarren]

Notes:

• disable solr entirely in test mode: sunspot/sunspot@b2dfd0e
• set Sunspot's session to a StubSessionProxy: http://stackoverflow.com/questions/5864470/disable-solr-during-database-rebuild (this could be used to make it not depend on the Solr service while running tests)
• ref'd in another issue, this is a gem allowing selective on/off of solr, though it's designed for RSpec: https://github.com/justinko/sunspot-rails-tester

[jywarren]

Whoa, i think setting disabled:true in sunspot.yml works -- i moved the searches_controller_test into its own folder, and will try to trigger that one with its own rake test:sunspot

[jywarren]

Got some more help here: http://flavio.castelli.name/2010/05/28/rails_execute_single_test/

Opened #861 which moves solr-dependent tests into a managed rake test:solr task, and adds it to the set run in rake test:all but not in rake test

[jywarren]

@icarito - is it possible to cache the java install, as that's failing in TravisCI pretty often. Although perhaps we should add priority to the plan to separate the Solr components into a separate docker instance, or use a pre-loaded one or something? I'm not familiar with how that works but could add it to this to-do list.