Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add online demo in gh-pages #14

Closed
jywarren opened this issue Aug 3, 2019 · 5 comments
Closed

Add online demo in gh-pages #14

jywarren opened this issue Aug 3, 2019 · 5 comments

Comments

@jywarren
Copy link
Member

jywarren commented Aug 3, 2019

This can be something really simple, which:

  1. shows 2 images in an html page
  2. has a button that says "find points"
  3. displays "100 points found in image A" and "100 points found in image B" or equivalent on completion
  4. has a second button that says "find matches"
  5. displays "20 matches found" on completion
  6. has a third button that says "suggest projection"
  7. uses CSS rotate and absolute-positioning to roughly overlay the 2nd image onto the first (i guess?)

This will provide a substantial guide to how to implement #5 and #11

Thanks!

@rexagod
Copy link
Member

rexagod commented Aug 18, 2019

@jywarren I've rendered the above factors and made some changes to the projection idea on the gh-pages deployment.

I've actually tried to show each matched point in one image wrt the other but overlapping them would have made it seem less discernable and while core actually "matches" the images, overlapping or "stitching" the images would result in images overlapped but shifted over each other (as you've seen in the sticher module) so I was unsure if that's what we needed here. However, if you want to show the stitching part in this as an example, we can probably drop a link of the LDI gh pages after merging the core into it?

This was referenced Aug 18, 2019
@jywarren
Copy link
Member Author

jywarren commented Aug 19, 2019 via email

@rexagod
Copy link
Member

rexagod commented Aug 19, 2019

@jywarren No need to downscale, core's inner mechanisms will take care of that. For the images above, I've redesigned the demo, so let me know what you think! Thanks!

@jywarren
Copy link
Member Author

jywarren commented Aug 20, 2019 via email

@rexagod
Copy link
Member

rexagod commented Aug 20, 2019

Sure thing! Closing this one now.

@rexagod rexagod closed this as completed Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants