Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated-L.Control.Layers initializer to class factory syntax #869

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

OzunaEddie
Copy link
Contributor

@OzunaEddie OzunaEddie commented Jul 19, 2019

Fixes #860 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codeclimate
Copy link

codeclimate bot commented Jul 19, 2019

Code Climate has analyzed commit 1aa959d and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #869 into main will decrease coverage by 3.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   72.43%   69.15%   -3.29%     
==========================================
  Files          35       35              
  Lines        1335     1355      +20     
==========================================
- Hits          967      937      -30     
- Misses        368      418      +50
Impacted Files Coverage Δ
app/controllers/feeds_controller.rb 0% <0%> (-100%) ⬇️

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OzunaEdd great job thank you!!

@sashadev-sky sashadev-sky merged commit e9d09ab into publiclab:main Jul 23, 2019
@welcome
Copy link

welcome bot commented Jul 23, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update L.Control.Layers initializer to class factory syntax
2 participants