Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar mistakes and change wording #727

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Conversation

fwsmit
Copy link
Contributor

@fwsmit fwsmit commented Jun 19, 2019

Fixes #723 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Jun 19, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codeclimate
Copy link

codeclimate bot commented Jun 19, 2019

Code Climate has analyzed commit 2b025d5 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@divyabaid16 divyabaid16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fwsmit All the changes you have made are really appretiated. It's an amazing work 🎉
I have suggested a few changes, please have a look at them and change them accordingly.
Thank you for your help 🎉 : 🎉
Thank you!

fwsmit and others added 2 commits June 19, 2019 16:32
Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com>
@fwsmit
Copy link
Contributor Author

fwsmit commented Jun 19, 2019

Thanks for the review!

@divyabaid16
Copy link
Contributor

Great!
Can anyone else from @publiclab/mapknitter-reviewers also review this?
Thanks!

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉 . Thanks for working on this @fwsmit and welcome to mapknitter!!

@jywarren jywarren merged commit 5987398 into publiclab:main Jun 19, 2019
@welcome
Copy link

welcome bot commented Jun 19, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Super!!! Thank you!!! 🎉

chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
* Fix grammar mistakes and change wording

* Slight grammar changes

Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com>

* Revert a change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct Grammatical mistake in MYSQL.md
4 participants