Removing problematic Warpable test #628
Conversation
|
Code Climate has analyzed commit 40beec4 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 72.19% 72.19%
=======================================
Files 31 31
Lines 1255 1255
=======================================
Hits 906 906
Misses 349 349 |
@jywarren @sashadev-sky According to this the test I have removed was not testing anything in our current code base. |
There was a problem hiding this comment.
@jywarren really has to make the call on this
Note it is meant to be testing export functionality and exists outside of the scope of the database. But as we've made a lot of progress in hooking it up to a cloud-based system maybe its time we can remove this? Or re-write it?
| @@ -49,16 +49,4 @@ def setup | |||
| assert_not_nil @warp.user_id | |||
| assert_equal @warp.map.user_id, @warp.user_id | |||
| end | |||
|
|
|||
| test "try export" do | |||
There was a problem hiding this comment.
Just a small observation. I guess we should try to make a standard for test naming, and use only either single or double quotes :)
There was a problem hiding this comment.
I'm kinda trying to solve those code pattern issues by enforcing a style guide(rubocop) in #547
|
@alaxalves check out Jeff's comment on #578 (comment). |
Thnx Cess, I'll close this for now. |
Fixes #627
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!