-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fully externalize exporter; untested #530
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,8 @@ group :dependencies do | |
gem "autoprefixer-rails" | ||
gem "uglifier" | ||
|
||
# switch to main version once ready: | ||
gem "mapknitter-exporter", git: 'https://github.com/publiclab/mapknitter-exporter', glob: '*.gemspec' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer single-quoted strings when you don't need string interpolation or special symbols. |
||
end | ||
|
||
group :test do | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
require "mapknitterExporter" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, @icarito i'm seeing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer single-quoted strings when you don't need string interpolation or special symbols. |
||
|
||
class Warpable < ActiveRecord::Base | ||
|
||
attr_accessible :image | ||
|
@@ -141,9 +143,8 @@ def url=(uri) | |
self.uploaded_data = io | ||
end | ||
|
||
# TODO: simplify/reduce # of parameters needed here: | ||
def generate_perspectival_distort(pxperm, path) | ||
Exporter.generate_perspectival_distort(pxperm, path, nodes_array, id, image_file_name, image, height, width) | ||
MapKnitterExporter.generate_perspectival_distort(pxperm, path, nodes_array, image_file_name, image.url(:original), height, width, Rails.root) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Line is too long. [145/80] |
||
end | ||
|
||
def user_id | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [103/80]