Fix front ui #1011
Merged
Fix front ui #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit ed655e4 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #1011 +/- ##
=========================================
- Coverage 73.7% 73.34% -0.37%
=========================================
Files 40 40
Lines 1388 1388
=========================================
- Hits 1023 1018 -5
- Misses 365 370 +5
|
|
@publiclab/mapknitter-reviewers |
|
Wow! This look amazing, love the new fonts and designs ❤️ 🎉 🎉. Maybe we should keep the publiclab icon. What do you think? |
|
Hi! This looks good, just re-using the already working code from the upper-right navbar dropdown. Super! Merging this now as I believe this resolves #1010 too? |
jywarren
approved these changes
Sep 11, 2019
|
Thank you Sasha!!! (Had trouble sleeping? wow, late night critical fixes FTW! 🙌 ) |
divyabaid16
reviewed
Sep 14, 2019
| </form> | ||
| <br><br> | ||
| <p>We strongly prefer that you should | ||
| <%= render partial: "layouts/login_form" %> | ||
| OR <a href="http://publiclab.org/signup">sign up for a Public Lab account</a> |
There was a problem hiding this comment.
Hi @sashadev-sky I think this line can be removed now.
chen-robert
pushed a commit
to chen-robert/mapknitter
that referenced
this pull request
Dec 5, 2019
* h * h * updates * fix front-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1012 (<=== Add issue number here)
The login view was missing in the public lab icon, and github icon:
Re-implemented it and DRYed up code by using the
_login_formpartial instead of rewriting the UI logic.Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/mapknitter-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!