Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve coords on making a new map from the view map page #1005

Merged
merged 4 commits into from
Sep 11, 2019

Conversation

jywarren
Copy link
Member

Post #777!

@codeclimate
Copy link

codeclimate bot commented Sep 10, 2019

Code Climate has analyzed commit 1a8fd2b and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #1005 into main will decrease coverage by 30.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            main    #1005       +/-   ##
==========================================
- Coverage   72.3%   42.02%   -30.29%     
==========================================
  Files         40       40               
  Lines       1394     1561      +167     
==========================================
- Hits        1008      656      -352     
- Misses       386      905      +519
Impacted Files Coverage Δ
app/controllers/maps_controller.rb 34.78% <ø> (-54.79%) ⬇️
app/mailers/comment_mailer.rb 0% <0%> (-100%) ⬇️
app/mailers/application_mailer.rb 0% <0%> (-100%) ⬇️
app/controllers/comments_controller.rb 0% <0%> (-100%) ⬇️
app/controllers/feeds_controller.rb 0% <0%> (-100%) ⬇️
app/controllers/utility_controller.rb 0% <0%> (-100%) ⬇️
app/controllers/users_controller.rb 0% <0%> (-94.12%) ⬇️
app/controllers/export_controller.rb 0% <0%> (-90.91%) ⬇️
app/controllers/tags_controller.rb 0% <0%> (-89.66%) ⬇️
app/controllers/images_controller.rb 0% <0%> (-75.65%) ⬇️
... and 10 more

@sashadev-sky
Copy link
Member

@jeff I just fixed these errors in #1001 . Rebase and your travis will pass.

@jywarren jywarren merged commit bdab16c into main Sep 11, 2019
@jywarren
Copy link
Member Author

Great!!!

chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
…#1005)

* preserve coords on making a new map from the view map page

* Update new.html.erb

* Update maps_controller.rb

* Update show.html.erb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants